JianyuWang0623 commented on PR #19963: URL: https://github.com/apache/nuttx/pull/19963#issuecomment-5410009071
Thanks for flagging this, @fdcavalcanti — good catch. If `EXAMPLES_LVGLTERM` switches from `select PSEUDOTERM` to `depends on PSEUDOTERM`, then `PSEUDOTERM` no longer gets auto-enabled, and these board defconfigs will need `CONFIG_PSEUDOTERM=y` explicitly again — which is exactly what this PR removes. So this PR would need to be reverted (at least the `PSEUDOTERM` part) once your nuttx-apps fix lands with `depends on`. Given that, fixing it on the nuttx-apps side sounds like the better and more root-cause-correct approach. I'll hold off on pushing this further until your fix is in — happy to close this PR if `depends on` is the direction you take, or keep just the `CONFIG_PIPES=y` cleanup (which is unrelated to `select`/`depends on` and stays valid either way). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
