acassis commented on code in PR #20219:
URL: https://github.com/apache/nuttx/pull/20219#discussion_r4081903779
##########
drivers/vhost/Kconfig:
##########
@@ -28,25 +22,15 @@ config DRIVERS_VHOST_NET
bool "Virtual Host Network Device Support"
default n
depends on NETDEVICES
+ select ARCH_HAVE_NETDEV_STATISTICS
select DRIVERS_VHOST
Review Comment:
Suggestion: instead of select DRIVERS_VHOST, it is better to use "depends on"
##########
drivers/vhost/Kconfig:
##########
@@ -8,16 +8,10 @@ config ARCH_HAVE_VHOST_IOMAP
default n
config DRIVERS_VHOST
- bool "Virtual Host (device-role virtio) support"
+ bool
Review Comment:
@zhhyu7 why to remove the user information? I think the user should
enable/disable the Virtual Host support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
