xiaoxiang781216 commented on code in PR #20219:
URL: https://github.com/apache/nuttx/pull/20219#discussion_r4083753672
##########
drivers/vhost/Kconfig:
##########
@@ -28,25 +22,15 @@ config DRIVERS_VHOST_NET
bool "Virtual Host Network Device Support"
default n
depends on NETDEVICES
+ select ARCH_HAVE_NETDEV_STATISTICS
select DRIVERS_VHOST
Review Comment:
@acassis the design of DRIVERS_VHOST follow Linux style, which is smarter
than the traditional NuttX Kconfig, for example the nuttx original design you
must set both CONFIG_DRIVERS_VHOST and CONFIG_DRIVERS_VHOST_NET to y in
defconfig to enable vhost-net. But, with the new design, you just need set
CONFIG_DRIVERS_VHOST_NET to y in default, DRIVERS_VHOST_NET will select
DRIVERS_VHOST in Kconfig and bring the base support into image behind the sense.
The rule of whether we should select or depend on a Kconfig option is
checking whether this option has prompt string:
1. no prompt string, you should select it in Kconfig
2. has prompt string, you should enable in in defconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
