xiaoxiang781216 commented on code in PR #20219:
URL: https://github.com/apache/nuttx/pull/20219#discussion_r4107763134


##########
drivers/vhost/Kconfig:
##########
@@ -28,25 +22,15 @@ config DRIVERS_VHOST_NET
        bool "Virtual Host Network Device Support"
        default n
        depends on NETDEVICES
+       select ARCH_HAVE_NETDEV_STATISTICS
        select DRIVERS_VHOST
        ---help---
                Device-role virtio-net: expose this side as a network card to a
                peer processor running a standard virtio-net driver (e.g. Linux
                via remoteproc), providing a NuttX ethN interface.
 
-config DRIVERS_VHOST_NET_MACADDR
-       hex "vhost-net MAC address"
-       default 0x025433000001

Review Comment:
   let's keep the config, but change default to 0, which mean generate the 
random mac address



##########
drivers/vhost/Kconfig:
##########
@@ -8,16 +8,10 @@ config ARCH_HAVE_VHOST_IOMAP
        default n
 
 config DRIVERS_VHOST
-       bool "Virtual Host (device-role virtio) support"
+       bool
        select OPENAMP
        select SCHED_WORKQUEUE
        default n
-       ---help---

Review Comment:
   keep



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to