ppisa commented on PR #19912: URL: https://github.com/apache/nuttx/pull/19912#issuecomment-5860708122
> > To move forward with NuttX, I suggest only to suppress warning for now. > > Agreed this may be the best option to avoid introducing other potential problems. But rather than muddying Microwindows .c source files with #ifdef NUTTX statements just to remove a warning for your build, I suggest putting the GCC #pragma in the config.nuttx file instead, so the warning(s) will always be suppressed. I am not sure, because catching this kind of problem early has some worth. This location is specially problematic due for MS unclear definition and it is relevant only for case which is probably really seldom used with NuttX or anything else embedded. Ability to catch similar problems when newly introduced would worth to be kept. On the other hand, I agree that change is a piece of mud. We can try to find NuttX build system option to suppress alignment warning only for this single file. If we find how to do that reliably, then it is the best option. Changing the tagMWDLGTEMPLATE to match other structure would solve the problem, but on the other hand for system without native unaligned support the code would be much longer and the problem propagates even to the caller subroutine. So after all rounds of thinking, my weak vote is to suppress warning only. Better only for single function or for single file to not mask some other problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
