acassis commented on code in PR #3825: URL: https://github.com/apache/nuttx-apps/pull/3825#discussion_r4233386268
########## examples/scl3300test/scl3300test_main.c: ########## @@ -0,0 +1,600 @@ +/**************************************************************************** + * apps/examples/scl3300test/scl3300test_main.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <errno.h> +#include <fcntl.h> +#include <inttypes.h> +#include <math.h> +#include <poll.h> +#include <stdbool.h> +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <sys/ioctl.h> +#include <unistd.h> + +#include <nuttx/sensors/ioctl.h> +#include <nuttx/sensors/scl3300.h> +#include <nuttx/uorb.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifdef CONFIG_SENSORS_USE_B16 +# define TODOUBLE(v) ((double)(v) / 65536.0) +#else +# define TODOUBLE(v) ((double)(v)) +#endif + +#define SCL3300TEST_WHOAMI 0xc1 +#define SCL3300TEST_NSAMPLES 200 /* Samples per noise measurement */ +#define SCL3300TEST_NSKIP 20 /* Samples dropped after a change */ +#define SCL3300TEST_NCYCLES 100 /* Power-down/wake-up cycles */ +#define SCL3300TEST_INTERVAL 10000 /* Sampling interval in us */ +#define SCL3300TEST_TIMEOUT 1000 /* Read timeout in ms */ + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static int g_devno; Review Comment: but it is variable is used in many different functions, there is not benefit in passing it over all those functions just to avoid a global variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
