zhhyu7 commented on PR #20627:
URL: https://github.com/apache/nuttx/pull/20627#issuecomment-6247618590
@Sarthak-Pandey , The features are now fairly robust, but there are still a
few areas in the code format that can be optimized. Once those are revised, I
should have no further comments.
tcp_input.c:1965: the two FIN_WAIT blocks are byte-identical
tcp_input.c:292: tcp_urg_input() two branches repeat ~20 lines
tcp_input.c:422: d_urglen written in all 3 branches; now write-only overall
tcp_send_buffered.c:1732: identical sq_addlast() in both #ifdef arms， simply
move sq_addlast out of the macro Code Block
tcp_appsend.c:324: tcp_send() duplicated to swap one argument
```
uint16_t sendflags = TCP_ACK | TCP_PSH; /* Unconditional Statement */
#ifdef CONFIG_NET_TCPURGDATA
if (conn->urg_offset > 0)
{
sendflags |= TCP_URG;
}
#endif
...
tcp_send(dev, conn, sendflags, dev->d_sndlen + hdrlen); /* Unified
tcp_send call */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
