zhhyu7 commented on PR #20627: URL: https://github.com/apache/nuttx/pull/20627#issuecomment-6236231154
@Sarthak-Pandey I don't know why I can't add comments to the modified code. There are mainly 3 issues, so I'll just list them directly in this reply: - net/tcp/tcp_input.c:1677 | SO_OOBINLINE never checked — urgent byte always stripped from the stream (removal sites at :1725 and :1771), contradicting the PR's own Kconfig:85-86 net/tcp/tcp_recvfrom.c:755 | companion: recv(MSG_OOB) must return EINVAL when SO_OOBINLINE is set, returns the byte instead - net/tcp/tcp_input.c:1429 | out-of-order URG announced but never resolved — segment goes through tcp_input_ofosegs() (:1422) into readahead via tcp_callback.c:112/322, bypassing the AWAITING branch at :1751 - net/tcp/tcp_input.c:1917 (+ :1941) | FIN_WAIT_1/FIN_WAIT_2 deliver payload at :1919/:1943 with no URG handling, since all of it sits inside case TCP_ESTABLISHED: (:1619) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
