Swatantra-66 commented on code in PR #20820: URL: https://github.com/apache/nuttx/pull/20820#discussion_r4359835290
########## syscall/syscall.csv: ########## @@ -129,7 +129,7 @@ "pthread_sigmask","pthread.h","!defined(CONFIG_DISABLE_PTHREAD)","int","int","FAR const sigset_t *","FAR sigset_t *" "pwrite","unistd.h","","ssize_t","int","FAR const void *","size_t","off_t" "read","unistd.h","","ssize_t","int","FAR void *","size_t" -"readv","sys/uio.h","","ssize_t","int","FAR const struct iovec *","int" +"readv","sys/uio.h","defined(CONFIG_FS_VECTORED_IO)","ssize_t","int","FAR const struct iovec *","int" Review Comment: Done. Kept `readv` and `writev` unconditional in POSIX headers and `syscall.csv`. When `CONFIG_FS_UIO` is disabled, `file_readv` and `file_writev` fall back to the driver's `read`/`write` callbacks (`file_readv_compat` / `file_writev_compat`). Standard `read()` and `write()` now call the driver operations directly, so the linker (`--gc-sections`) automatically strips `readv`, `writev`, and `fs_uio.o` from flash when unused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
