Swatantra-66 commented on PR #20820: URL: https://github.com/apache/nuttx/pull/20820#issuecomment-6381107398
@jingfei195887 ,That's a valid point for saving additional RAM/pointers, but it is definitely better suited as a separate follow-up PR. Guarding `readv`/`writev` inside `struct file_operations` and `struct mountpt_operations` would break any in-tree and out-of-tree drivers or filesystems using designated initializers (`.readv = ...`, `.writev = ...`) or positional initializers when `CONFIG_FS_UIO=n`. It also requires updating member references across the tree (e.g. `fs_truncate.c`) and carefully synchronizing the union layout between `file_operations` and `mountpt_operations`. Keeping the struct layout unchanged here allows `CONFIG_FS_UIO` to safely deliver the core code-size and stack savings without risking widespread driver breakage. We can explore conditionally guarding the struct fields in a dedicated follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
