jingfei195887 commented on PR #20820: URL: https://github.com/apache/nuttx/pull/20820#issuecomment-6370611290
Would it make sense to also guard the readv/writev members of both struct file_operations and struct mountpt_operations with CONFIG_FS_UIO? Since the native vector callbacks are not used when FS_UIO is disabled, this could save two function pointers per retained operations table in addition to the code-size savings. I realize this would require updating the positional initializers and other member references (for example, the writev check in fs_truncate.c), while keeping the common layout of the two structures consistent. Would you consider including this, or would it be better suited to a follow-up change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
