xiaoxiang781216 commented on pull request #2061: URL: https://github.com/apache/incubator-nuttx/pull/2061#issuecomment-715215040
> @xiaoxiang781216, @MasayukiIshikawa, @Ouss4 > > I would like to test this on HW. > Sure, let's wait your test. > I also think we need to define Top, bottom, base in terms of addresses. > > Thing like this read wrong > > `if (sp < istackbase && sp > istackbase - istacksize)` > > high address > <- top, bound > > <-sp > <- bottom, base > low addresses > Yes, the term usage is strange, but it is an unrelated issue. It's better to create new PR to fix the term issue. > I need to review this more carefully, but it look to me that were are adding instructions for alignment when the compiler can do it. > We need to all ways allocate larger for alignment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
