davids5 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510786581



##########
File path: arch/arm/src/armv7-m/gnu/arm_exception.S
##########
@@ -321,9 +322,9 @@ exception_common:
        .bss
        .global g_intstackalloc
        .global g_intstackbase
-       .align  8
+       .balign 8
 g_intstackalloc:
-       .skip   ((CONFIG_ARCH_INTERRUPTSTACK + 4) & ~7)
+       .skip   (CONFIG_ARCH_INTERRUPTSTACK & ~7)

Review comment:
       Here is the thing. Nuttx does not support nested interrupt. If a design 
is super low on memory (it happens) the interrupt stack allocation has to not 
round down.  If  know the CONFIG (FPU etc) the size of the int stack is a fixed 
number . If I ask for That number and get a stack that is less it will over 
write memory.  This will be a debugging nightmare! Please round it UP




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to