davids5 commented on pull request #2061: URL: https://github.com/apache/incubator-nuttx/pull/2061#issuecomment-715313224
> > @masayuki2009 - I have tested this. My only 2 concerns are 1) Not rounding UP (see [#2061 (comment)] > > The rounddown exist for a long time and nobody complain this behvaiour. if you think the roundup is better, please create a new PR to fix it. > > ([#2061 (comment)](https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510786581))), and 2 this change: > > >  > > Would you help me understand if is it correct? > > Are we using Descending Empty or Descending Full? > > We can't select here, ARM require the descending full stack: > https://static.docs.arm.com/ihi0042/f/IHI0042F_aapcs.pdf Thanks @xiaoxiang781216 So.. Descending-full then implies: SP ->last write. push is decrement then store Correct? Then isn't the changes with SP-X wrong? The value at [SP-X] get overwritten by any push's in the call chain of arm_decodeirq. Or am I seeing this incorrectly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
