xiaoxiang781216 commented on a change in pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#discussion_r675760900
##########
File path: include/sys/types.h
##########
@@ -175,6 +183,16 @@ typedef int wint_t;
typedef int wctype_t;
+#if defined(CONFIG_FS_LARGEFILE) && defined(CONFIG_HAVE_LONG_LONG)
+/* Large file versions */
+
+typedef uint64_t fsblkcnt_t;
+typedef uint64_t fsfilcnt_t;
+
+typedef uint64_t blkcnt_t;
+typedef int64_t off_t;
Review comment:
fsfilcnt_t may not, but block count is related to large file support.
For example, my laptop buyed two years ago has a SSD with 2TB, if the sector is
512B, 32bit block count can't represent my old SSD correctly. Other libc has
the similar change for both fsfilcnt_t and blkcnt_t:
https://github.com/bminor/musl/blob/cfdfd5ea3ce14c6abf7fb22a531f3d99518b5a1b/include/sys/types.h#L74-L80
https://github.com/bminor/glibc/blob/595c22ecd8e87a27fd19270ed30fdbae9ad25426/posix/bits/types.h#L179-L189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
