davids5 edited a comment on pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#issuecomment-891253623


   @xiaoxiang781216  I am not understanding the change. I thought the left side 
was the "correct way" What was the reason for these:
   
   
![image](https://user-images.githubusercontent.com/1945821/127908298-f9062208-f14e-4497-8f79-1c0bc801d95c.png)
   
   Did you back them out to save on the code space? Would you explain how this 
works when on a 32 bit machine with large support? Are we going to truncate the 
offsets in debug?  
   
   Would something like 
[this](https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/)
 be better all the way around?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to