davids5 commented on pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#issuecomment-891194513
@xiaoxiang781216 - I have tested this and it is working well with and
without Large File Support turned on.
The Knob was very worthwhile.!
master + these commits
LFS not enabled compared to enabled
```
VM SIZE
--------------
+0.2% +3.33Ki .text
+41% +176 ftl_write
+54% +152 fat_checkbootrecord
+34% +116 fat_seek
+26% +112 fat_write
+39% +96 fat_dirextend
+29% +80 cromfs_read
+21% +78 fat_allocatedirentry
+28% +70 fat_putcluster
+31% +64 mtd_partition
+97% +62 part_read
+97% +62 part_write
[NEW] +60 cdev::cdev_seek(file*, long long, int)
+30% +58 fat_getcluster
+5.9% +56 fat_finddirentry
+6.4% +56 hardfault_commit.constprop.0
+11% +56 px4::logger::util::check_free_space(char const*, long,
void*&, int&)
+56% +54 fat_nextdirentry
+104% +48 part_erase
+55% +48 romfs_seek
+58% +44 stm32_bbsram_seek
+35% +42 fat_computefreeclusters
+12% +42 fat_read
+105% +42 part_bread
+105% +42 part_bwrite
+50% +40 bch_seek
+13% +40 fat_mount
+28% +40 fat_truncate
+59% +38 stm32_bbsram_read
+22% +36 at24c_bwrite
+5.7% +36 bl_update_main
+62% +36 fat_currentsector
+25% +36 fat_extendchain
+27% +34 fat_dirshrink
+8.9% +34 fat_mkdir
+34% +34 stm32_bbsram_write
+19% +32 _file_restart(dm_reset_reason)
+27% +32 fat_freedirentry
+114% +32 ramtron_bread
+35% +30 fat_fscacheflush
+16% +28 at24c_bread
+27% +28 fat_rewinddir
+44% +28 file_seek
+1.8% +28 proc_read
+14% +26 inode_stat
+30% +24 mount_read
+8.3% +24 mtd_rwtest(mtd_instance_s const&)
+55% +24 procfs_memcpy
+41% +24 rd_write
+16% +22 fat_dup
+17% +22 fat_stat_file
+44% +22 rd_read
+13% +20 _file_clear(dm_item_t)
+24% +20 blocks_entry
+2.0% +20 fat_putlfname
+26% +20 ftell
+77% +20 lseek
+67% +20 nx_seek
+24% +20 romfs_opendir
+15% +18 fat_findsfnentry
+14% +18 fat_opendir
+64% +18 gpio_seek
+16% +18 part_ioctl
+18% +18 romfs_stat_common
+6.3% +16 MavlinkStreamStorageInformation::send()
+62% +16 fat_cluster2sector
+26% +16 fat_ffcacheread
+38% +16 fat_fscacheread
+6.4% +16 files_allocate
+13% +16 romfs_readdir
+14% +16 uptime_read
+5.0% +16 usage_entry
+17% +16 version_read
+4.3% +14 fat_open
+6.4% +14 readdir
+12% +12 MavlinkFTP::_workWrite(MavlinkFTP::PayloadHeader*)
+7.9% +12 _file_read(dm_item_t, unsigned int, void*, unsigned int)
+27% +12 fat_ffcacheflush
+6.8% +12 fat_readdir
+27% +12 gpio_read
+4.5% +12 iobinfo_read
+2.8% +12 meminfo_read
+6.7% +12 part_procfs_read
+3.3% +12 procfs_readdir
+4.5% +12
uavcan_posix::BasicFileServerBackend::read(uavcan::Array<uavcan::IntegerSpec<8u,
(uavcan::Signedness)0, (uavcan::CastMode)0>, (uavcan::ArrayMode)1, 200u>
const&, unsigned long long, unsigned char*, unsigned short&)
+6.8% +10 bson_encoder_fini(bson_encoder_s*)
[NEW] +10 cdev::CDev::seek(file*, long long, int)
+4.7% +10 fat_remove
+4.2% +10 file_vopen
+3.8% +10 romfs_finddirentry
+12% +10 romfs_statfs
+6.9% +8 MavlinkFTP::_workRead(MavlinkFTP::PayloadHeader*)
+6.7% +8 PreFlightCheck::sdcardCheck(void**, bool&, bool)
+0.0% +8 [section .text]
+5.6% +8 _file_write(dm_item_t, unsigned int, dm_persitence_t,
void const*, unsigned int)
+14% +8 bch_read
+11% +8 bch_write
+50% +8 binfs_fstat
+17% +8 binfs_stat
+17% +8 cromfs_statfs
+1.0% +8 expression
+1.8% +8 fat_dirname2path
+11% +8 fat_dirtruncate
+21% +8 fat_findalias
+9.1% +8 fat_statfs
+25% +8 netprocfs_read
+8.3% +8 netprocfs_stat
+50% +8 part_procfs_stat
+29% +8 procfs_statfs
+0.8% +8 px4_mtd_config
+4.3% +8 romfs_read
+2.2% +8 update(char const*, char const*)
+19% +6 bchlib_flushsector
+3.1% +6 bchlib_read
+13% +6 bchlib_readsector
+2.7% +6 bchlib_write
+23% +6 binfs_statfs
+16% +6 fat_ffcacheinvalidate
+14% +6 file_close
+4.1% +6 file_dup2
+10.0% +6 fseek
+3.4% +6 ipcfg_read_binary_ipv4
+2.8% +6 opendir
+2.9% +4 MavlinkFTP::_workOpen(MavlinkFTP::PayloadHeader*, int)
+1.3% +4
MavlinkFTP::_workTruncateFile(MavlinkFTP::PayloadHeader*)
+1.1% +4 MavlinkFTP::send()
+1.9% +4 PX4IO_Uploader::program(unsigned int)
+1.3% +4 PX4IO_Uploader::verify_rev2(unsigned int)
+9.5% +4 cromfs_fstat
+5.9% +4 cromfs_stat
+5.0% +4 fat_fstat
+11% +4 fat_hwread
+11% +4 fat_hwwrite
+1.5% +4 fat_rename
+3.6% +4 fat_updatefsinfo
+6.7% +4 file_dup
+4.0% +4 files_duplist
+50% +4 gpio_open
+0.7% +4 hardfault_write
+6.2% +4 nx_vopen
+2.7% +4 param_import_internal(int, bool)
+4.8% +4 proc_readdir
+10.0% +4 romfs_rewinddir
+11% +4 sockfd_allocate
+5.0% +4 write_intterupt_stack.constprop.0
+5.0% +4 write_user_stack.constprop.0
+4.5% +2 binfs_readdir
+1.0% +2 cromfs_readdir
+3.6% +2 fat_checkmount
+5.6% +2 fat_nfreeclusters
+1.0% +2 fat_sync
+2.1% +2 fs_getfilep
+6.2% +2 ftl_geometry
+2.1% +2 mmcsd_geometry
+2.2% +2 netprocfs_readdir
+1.7% +2 nx_close
+1.5% +2 nx_dup2
+0.9% +2 ramtron_bwrite
+5.9% +2 rd_geometry
+2.9% +2 romfs_checkmount
+1.0% +2 romfs_open
-2.8% -2 fat_removechain
-1.7% -2 ramtron_read
-2.1% -2 romfs_hwread
-12.5% -4 ftl_read
-3.1% -4 hardfault_increment_reboot
[DEL] -6 cdev::CDev::seek(file*, long, int)
[DEL] -56 cdev::cdev_seek(file*, long, int)
+0.2% +3.33Ki TOTAL
```
Master @8660572a3c69e0e2ca24c3cabeaaaae3372a6960 compared to these commits
enabled
```
VM SIZE
--------------
+0.2% +3.29Ki .text
[NEW] +216 fnmatch_one
+41% +176 ftl_write
+54% +152 fat_checkbootrecord
[NEW] +140 default_gpios.9884
[NEW] +140 gpio.11297
[NEW] +120 commands.23401
+34% +116 fat_seek
+26% +112 fat_write
[NEW] +108 work_thread
[NEW] +108 work_thread_create.constprop.0
+39% +96 fat_dirextend
+29% +80 cromfs_read
+143% +80 work_queue
+21% +78 fat_allocatedirentry
+28% +70 fat_putcluster
[NEW] +66 fnmatch
+31% +64 mtd_partition
+97% +62 part_read
+97% +62 part_write
[NEW] +60 cdev::cdev_seek(file*, long long, int)
+30% +58 fat_getcluster
+1.8% +56 [28 Others]
+5.9% +56 fat_finddirentry
+6.4% +56 hardfault_commit.constprop.0
+11% +56 px4::logger::util::check_free_space(char const*, long,
void*&, int&)
+56% +54 fat_nextdirentry
[NEW] +52 hp_work_timer_expiry
[NEW] +52 lp_work_timer_expiry
[NEW] +48 page_sizes.7944
+104% +48 part_erase
+55% +48 romfs_seek
[NEW] +44 dn2o.8887
+58% +44 stm32_bbsram_seek
+35% +42 fat_computefreeclusters
+12% +42 fat_read
+105% +42 part_bread
+105% +42 part_bwrite
+50% +40 bch_seek
+13% +40 fat_mount
+28% +40 fat_truncate
+59% +38 stm32_bbsram_read
+22% +36 at24c_bwrite
+5.7% +36 bl_update_main
+62% +36 fat_currentsector
+25% +36 fat_extendchain
+27% +34 fat_dirshrink
+8.9% +34 fat_mkdir
+34% +34 stm32_bbsram_write
+19% +32 _file_restart(dm_reset_reason)
+27% +32 fat_freedirentry
+114% +32 ramtron_bread
+35% +30 fat_fscacheflush
+16% +28 at24c_bread
+27% +28 fat_rewinddir
+44% +28 file_seek
+1.8% +28 proc_read
+14% +26 inode_stat
+30% +24 mount_read
+8.3% +24 mtd_rwtest(mtd_instance_s const&)
+55% +24 procfs_memcpy
+41% +24 rd_write
+16% +22 fat_dup
+17% +22 fat_stat_file
[NEW] +22 format.8416
+44% +22 rd_read
+13% +20 _file_clear(dm_item_t)
[NEW] +20 baudrates.11002
[NEW] +20 baudrates_to_try.10178
+24% +20 blocks_entry
+2.0% +20 fat_putlfname
+26% +20 ftell
+77% +20 lseek
+67% +20 nx_seek
+24% +20 romfs_opendir
+15% +18 fat_findsfnentry
+14% +18 fat_opendir
+64% +18 gpio_seek
+16% +18 part_ioctl
+18% +18 romfs_stat_common
+6.3% +16 MavlinkStreamStorageInformation::send()
[NEW] +16 __FUNCTION__.8397
+62% +16 fat_cluster2sector
+26% +16 fat_ffcacheread
+38% +16 fat_fscacheread
+6.4% +16 files_allocate
+13% +16 romfs_readdir
[NEW] +16 sensors_channels.17663
+14% +16 uptime_read
+5.0% +16 usage_entry
+17% +16 version_read
[NEW] +14 __FUNCTION__.8035
+4.3% +14 fat_open
+6.4% +14 readdir
[NEW] +13 __FUNCTION__.8381
[NEW] +13 __FUNCTION__.8407
+12% +12 MavlinkFTP::_workWrite(MavlinkFTP::PayloadHeader*)
[NEW] +12 __FUNCTION__.8389
+7.9% +12 _file_read(dm_item_t, unsigned int, void*, unsigned int)
+27% +12 fat_ffcacheflush
+6.8% +12 fat_readdir
+27% +12 gpio_read
+4.5% +12 iobinfo_read
+2.8% +12 meminfo_read
+6.7% +12 part_procfs_read
+3.3% +12 procfs_readdir
+4.5% +12
uavcan_posix::BasicFileServerBackend::read(uavcan::Array<uavcan::IntegerSpec<8u,
(uavcan::Signedness)0, (uavcan::CastMode)0>, (uavcan::ArrayMode)1, 200u>
const&, unsigned long long, unsigned char*, unsigned short&)
+21% +12 work_qcancel
[NEW] +10 __FUNCTION__.8416
+6.8% +10 bson_encoder_fini(bson_encoder_s*)
[NEW] +10 cdev::CDev::seek(file*, long long, int)
+4.7% +10 fat_remove
+4.2% +10 file_vopen
+3.8% +10 romfs_finddirentry
+12% +10 romfs_statfs
+6.9% +8 MavlinkFTP::_workRead(MavlinkFTP::PayloadHeader*)
+6.7% +8 PreFlightCheck::sdcardCheck(void**, bool&, bool)
+5.6% +8 _file_write(dm_item_t, unsigned int, dm_persitence_t,
void const*, unsigned int)
+14% +8 bch_read
+11% +8 bch_write
+50% +8 binfs_fstat
+9.1% +8 binfs_operations
+17% +8 binfs_stat
+9.1% +8 cromfs_operations
+17% +8 cromfs_statfs
+1.0% +8 expression
+1.8% +8 fat_dirname2path
+11% +8 fat_dirtruncate
+21% +8 fat_findalias
+9.1% +8 fat_operations
+9.1% +8 fat_statfs
[NEW] +8 min_available.14907
+25% +8 netprocfs_read
+8.3% +8 netprocfs_stat
+50% +8 part_procfs_stat
+9.1% +8 procfs_operations
+29% +8 procfs_statfs
+0.8% +8 px4_mtd_config
+9.1% +8 romfs_operations
+4.3% +8 romfs_read
+2.2% +8 update(char const*, char const*)
+19% +6 bchlib_flushsector
+3.1% +6 bchlib_read
+13% +6 bchlib_readsector
+2.7% +6 bchlib_write
+23% +6 binfs_statfs
+16% +6 fat_ffcacheinvalidate
+14% +6 file_close
+4.1% +6 file_dup2
+10.0% +6 fseek
+3.4% +6 ipcfg_read_binary_ipv4
+2.8% +6 opendir
[NEW] +5 labels.8590
+2.9% +4 MavlinkFTP::_workOpen(MavlinkFTP::PayloadHeader*, int)
+1.3% +4
MavlinkFTP::_workTruncateFile(MavlinkFTP::PayloadHeader*)
+1.1% +4 MavlinkFTP::send()
+1.9% +4 PX4IO_Uploader::program(unsigned int)
+1.3% +4 PX4IO_Uploader::verify_rev2(unsigned int)
+0.0% +4 [section .text]
+9.5% +4 cromfs_fstat
+5.9% +4 cromfs_stat
+5.0% +4 fat_fstat
+11% +4 fat_hwread
+11% +4 fat_hwwrite
+1.5% +4 fat_rename
+3.6% +4 fat_updatefsinfo
+6.7% +4 file_dup
+18% +4 file_socket
+4.0% +4 files_duplist
+50% +4 gpio_open
-12.5% -4 ftl_read
-0.0% -4 g_cromfs_image
-3.1% -4 hardfault_increment_reboot
[DEL] -5 labels.8564
[DEL] -6 cdev::CDev::seek(file*, long, int)
[DEL] -8 min_available.14884
-0.9% -8 mmcsd_probe
[DEL] -10 __FUNCTION__.8393
[DEL] -12 __FUNCTION__.8366
[DEL] -13 __FUNCTION__.8358
[DEL] -13 __FUNCTION__.8384
[DEL] -14 __FUNCTION__.8012
[DEL] -16 __FUNCTION__.8374
[DEL] -16 sensors_channels.17636
[DEL] -20 baudrates.10979
[DEL] -20 baudrates_to_try.10155
[DEL] -20 work_hpthread
[DEL] -20 work_lpthread
[DEL] -22 format.8393
[DEL] -44 dn2o.8864
[DEL] -44 work_signal
[DEL] -48 page_sizes.7921
-66.7% -48 work_start_highpri
-66.7% -48 work_start_lowpri
[DEL] -56 cdev::cdev_seek(file*, long, int)
[DEL] -58 match
[DEL] -84 work_qqueue
[DEL] -120 commands.23378
[DEL] -140 default_gpios.9857
[DEL] -140 gpio.11171
[DEL] -216 match_one
[DEL] -224 work_process
+0.1% +64 .bss
[NEW] +44 tm.5737
+5.5% +24 [section .bss]
[NEW] +20 buffer.7938
[NEW] +20 channels_cache.9223
+167% +20 g_hpwork
+167% +20 g_lpwork
[NEW] +18 buffer.7997
[NEW] +8 base_time.8779
[NEW] +4 inited.6149
[NEW] +4 last_count.8780
[NEW] +4 new_channel_count.8757
[NEW] +4 new_channel_holdoff.8758
[NEW] +4 notifier_key.8193
[NEW] +4 rxdummy.8521
[NEW] +2 g_last_tcp_port.7385
[NEW] +2 g_last_udp_port.7233
[NEW] +1 initialized.5962
[NEW] +1 initialized.8270
[NEW] +1 once.8128
[NEW] +1 state.8384
[DEL] -1 initialized.5964
[DEL] -1 initialized.8247
[DEL] -1 once.8105
[DEL] -1 state.8361
[DEL] -2 g_last_tcp_port.7368
[DEL] -2 g_last_udp_port.7216
[DEL] -4 inited.6151
[DEL] -4 last_count.8757
[DEL] -4 new_channel_count.8734
[DEL] -4 new_channel_holdoff.8735
[DEL] -4 notifier_key.8169
[DEL] -4 rxdummy.8498
[DEL] -8 base_time.8756
[DEL] -18 buffer.7974
[DEL] -20 buffer.7915
[DEL] -20 channels_cache.9200
[DEL] -44 tm.5739
+0.2% +3.35Ki TOTAL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
