pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r857266084
##########
arch/arm/src/lpc54xx/lpc54_rtc_lowerhalf.c:
##########
@@ -169,14 +169,14 @@ static struct lpc54_lowerhalf_s g_rtc_lowerhalf =
#ifdef CONFIG_RTC_ALARM
static void lpc54_alarm_callback(void)
{
- FAR struct lpc54_cbinfo_s *cbinfo = &g_rtc_lowerhalf.cbinfo;
+ struct lpc54_cbinfo_s *cbinfo = &g_rtc_lowerhalf.cbinfo;
/* Sample and clear the callback information to minimize the window in
* time in which race conditions can occur.
*/
rtc_alarm_callback_t cb = (rtc_alarm_callback_t)cbinfo->cb;
- FAR void *arg = (FAR void *)cbinfo->priv;
+ void *arg = (void *)cbinfo->priv;
Review Comment:
```suggestion
void *arg = (void *)cbinfo->priv;
```
##########
arch/arm/src/max326xx/max32660/max32660_wdt.c:
##########
@@ -79,35 +79,35 @@
struct max326_wdt_lowerhalf_s
{
- FAR const struct watchdog_ops_s *ops; /* Lower half operations */
- uint8_t exp; /* log12(Reset time period) */
- xcpt_t handler; /* User interrupt handler */
- clock_t lastping; /* Time of last WDT reset */
+ const struct watchdog_ops_s *ops; /* Lower half operations */
+ uint8_t exp; /* log12(Reset time period) */
+ xcpt_t handler; /* User interrupt handler */
+ clock_t lastping; /* Time of last WDT reset */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
static inline void
-max326_wdog_reset(FAR struct max326_wdt_lowerhalf_s *priv);
-static void max326_int_enable(FAR struct max326_wdt_lowerhalf_s *priv);
-static uint32_t max326_time_left(FAR struct max326_wdt_lowerhalf_s *priv);
+max326_wdog_reset(struct max326_wdt_lowerhalf_s *priv);
+static void max326_int_enable(struct max326_wdt_lowerhalf_s *priv);
+static uint32_t max326_time_left(struct max326_wdt_lowerhalf_s *priv);
static uint64_t max326_exp2msec(uint32_t pclk, uint8_t exp);
static uint8_t max326_msec2exp(uint32_t msec);
/* "Lower half" driver methods **********************************************/
-static int max326_start(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_stop(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_keepalive(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status);
-static int max326_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int max326_start(struct watchdog_lowerhalf_s *lower);
+static int max326_stop(struct watchdog_lowerhalf_s *lower);
+static int max326_keepalive(struct watchdog_lowerhalf_s *lower);
+static int max326_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status);
Review Comment:
```suggestion
struct watchdog_status_s *status);
```
##########
arch/arm/src/max326xx/max32660/max32660_wdt.c:
##########
@@ -466,11 +466,11 @@ static int max326_keepalive(FAR struct
watchdog_lowerhalf_s *lower)
*
****************************************************************************/
-static int max326_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status)
+static int max326_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status)
Review Comment:
```suggestion
struct watchdog_status_s *status)
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -920,10 +920,10 @@ static int nrf52_adc_ioctl(FAR struct adc_dev_s *dev, int
cmd,
****************************************************************************/
struct adc_dev_s *nrf52_adcinitialize(
- FAR const struct nrf52_adc_channel_s *chan, int channels)
+ const struct nrf52_adc_channel_s *chan, int channels)
{
- FAR struct adc_dev_s *dev = NULL;
- FAR struct nrf52_adc_s *priv = NULL;
+ struct adc_dev_s *dev = NULL;
+ struct nrf52_adc_s *priv = NULL;
int i = 0;
Review Comment:
```suggestion
int i = 0;
```
##########
arch/arm/src/nrf52/nrf52_gpiote.c:
##########
@@ -54,7 +54,7 @@
struct nrf52_gpiote_callback_s
{
xcpt_t callback;
Review Comment:
```suggestion
xcpt_t callback;
```
##########
arch/arm/src/nrf52/nrf52_tim_lowerhalf.c:
##########
@@ -71,14 +71,14 @@ static int nrf52_timer_handler(int irq, void *context, void
*arg);
/* "Lower half" driver methods **********************************************/
-static int nrf52_timer_start(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_stop(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int nrf52_timer_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int nrf52_timer_start(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_stop(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int nrf52_timer_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
-static void nrf52_timer_setcallback(FAR struct timer_lowerhalf_s *lower,
- tccb_t callback, FAR void *arg);
+static void nrf52_timer_setcallback(struct timer_lowerhalf_s *lower,
+ tccb_t callback, void *arg);
Review Comment:
```suggestion
static void nrf52_timer_setcallback(struct timer_lowerhalf_s *lower,
tccb_t callback, void *arg);
```
##########
arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c:
##########
@@ -87,14 +87,14 @@ static int phyplus_timer_handler(int irq, void * context,
void * arg);
/* "Lower half" driver methods **********************************************/
-static int phyplus_start(FAR struct timer_lowerhalf_s *lower);
-static int phyplus_stop(FAR struct timer_lowerhalf_s *lower);
-static int phyplus_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int phyplus_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int phyplus_start(struct timer_lowerhalf_s *lower);
+static int phyplus_stop(struct timer_lowerhalf_s *lower);
+static int phyplus_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int phyplus_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
-static void phyplus_setcallback(FAR struct timer_lowerhalf_s *lower,
- tccb_t callback, FAR void *arg);
+static void phyplus_setcallback(struct timer_lowerhalf_s *lower,
+ tccb_t callback, void *arg);
Review Comment:
```suggestion
static void phyplus_setcallback(struct timer_lowerhalf_s *lower,
tccb_t callback, void *arg);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR const uint8_t *buf);
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+ const uint8_t *buf);
+static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
Review Comment:
```suggestion
static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
Review Comment:
```suggestion
uint8_t *buf);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -184,10 +184,10 @@ static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
* Name: pplus_fls_bread
****************************************************************************/
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev, off_t startblock,
- size_t nblocks, FAR uint8_t *buffer)
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev, off_t startblock,
+ size_t nblocks, uint8_t *buffer)
Review Comment:
```suggestion
static ssize_t pplus_fls_bread(struct mtd_dev_s *dev, off_t startblock,
size_t nblocks, uint8_t *buffer)
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -650,8 +647,8 @@ struct lpc31_req_s *lpc31_rqdequeue(FAR struct lpc31_ep_s
*privep)
*
****************************************************************************/
-static bool lpc31_rqenqueue(FAR struct lpc31_ep_s *privep,
- FAR struct lpc31_req_s *req)
+static bool lpc31_rqenqueue(struct lpc31_ep_s *privep,
+ struct lpc31_req_s *req)
Review Comment:
```suggestion
static bool lpc31_rqenqueue(struct lpc31_ep_s *privep,
struct lpc31_req_s *req)
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -727,9 +727,9 @@ static void nrf52_adc_reset(FAR struct adc_dev_s *dev)
*
****************************************************************************/
-static int nrf52_adc_setup(FAR struct adc_dev_s *dev)
+static int nrf52_adc_setup(struct adc_dev_s *dev)
{
- FAR struct nrf52_adc_s *priv = (FAR struct nrf52_adc_s *) dev->ad_priv;
+ struct nrf52_adc_s *priv = (struct nrf52_adc_s *) dev->ad_priv;
int i = 0;
int ret = OK;
Review Comment:
```suggestion
struct nrf52_adc_s *priv = (struct nrf52_adc_s *) dev->ad_priv;
int i = 0;
int ret = OK;
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -1979,11 +1976,11 @@ static int lpc31_usbinterrupt(int irq, FAR void
*context, FAR void *arg)
*
****************************************************************************/
-static int lpc31_epconfigure(FAR struct usbdev_ep_s *ep,
- FAR const struct usb_epdesc_s *desc,
+static int lpc31_epconfigure(struct usbdev_ep_s *ep,
+ const struct usb_epdesc_s *desc,
bool last)
Review Comment:
```suggestion
static int lpc31_epconfigure(struct usbdev_ep_s *ep,
const struct usb_epdesc_s *desc,
bool last)
```
##########
arch/arm/src/lpc54xx/lpc54_lcd.c:
##########
@@ -385,8 +385,8 @@ static int lpc54_getcursor(FAR struct fb_vtable_s *vtable,
****************************************************************************/
#ifdef CONFIG_FB_HWCURSOR
-static int lpc54_setcursor(FAR struct fb_vtable_s *vtable,
- FAR struct fb_setcursor_s *settings)
+static int lpc54_setcursor(struct fb_vtable_s *vtable,
+ struct fb_setcursor_s *settings)
Review Comment:
```suggestion
static int lpc54_setcursor(struct fb_vtable_s *vtable,
struct fb_setcursor_s *settings)
```
##########
arch/arm/src/nrf52/nrf52_radio.c:
##########
@@ -991,9 +991,9 @@ static int nrf52_radio_isr_tx(FAR struct nrf52_radio_dev_s
*dev)
*
****************************************************************************/
-static int nrf52_radio_isr(int irq, FAR void *context, FAR void *arg)
+static int nrf52_radio_isr(int irq, void *context, void *arg)
{
- FAR struct nrf52_radio_dev_s *dev = (FAR struct nrf52_radio_dev_s *)arg;
+ struct nrf52_radio_dev_s *dev = (struct nrf52_radio_dev_s *)arg;
int ret = OK;
uint32_t state = 0;
Review Comment:
```suggestion
int ret = OK;
uint32_t state = 0;
```
##########
arch/arm/src/max326xx/max32660/max32660_wdt.c:
##########
@@ -523,11 +523,11 @@ static int max326_getstatus(FAR struct
watchdog_lowerhalf_s *lower,
*
****************************************************************************/
-static int max326_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int max326_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
uint32_t timeout)
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -858,10 +858,10 @@ static void nrf52_adc_rxint(FAR struct adc_dev_s *dev,
bool enable)
*
****************************************************************************/
-static int nrf52_adc_ioctl(FAR struct adc_dev_s *dev, int cmd,
+static int nrf52_adc_ioctl(struct adc_dev_s *dev, int cmd,
unsigned long arg)
{
- FAR struct nrf52_adc_s *priv = (FAR struct nrf52_adc_s *) dev->ad_priv;
+ struct nrf52_adc_s *priv = (struct nrf52_adc_s *) dev->ad_priv;
int ret = OK;
Review Comment:
```suggestion
int ret = OK;
```
##########
arch/arm/src/max326xx/max32660/max32660_wdt.c:
##########
@@ -79,35 +79,35 @@
struct max326_wdt_lowerhalf_s
{
- FAR const struct watchdog_ops_s *ops; /* Lower half operations */
- uint8_t exp; /* log12(Reset time period) */
- xcpt_t handler; /* User interrupt handler */
- clock_t lastping; /* Time of last WDT reset */
+ const struct watchdog_ops_s *ops; /* Lower half operations */
+ uint8_t exp; /* log12(Reset time period) */
+ xcpt_t handler; /* User interrupt handler */
+ clock_t lastping; /* Time of last WDT reset */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
static inline void
-max326_wdog_reset(FAR struct max326_wdt_lowerhalf_s *priv);
-static void max326_int_enable(FAR struct max326_wdt_lowerhalf_s *priv);
-static uint32_t max326_time_left(FAR struct max326_wdt_lowerhalf_s *priv);
+max326_wdog_reset(struct max326_wdt_lowerhalf_s *priv);
+static void max326_int_enable(struct max326_wdt_lowerhalf_s *priv);
+static uint32_t max326_time_left(struct max326_wdt_lowerhalf_s *priv);
static uint64_t max326_exp2msec(uint32_t pclk, uint8_t exp);
static uint8_t max326_msec2exp(uint32_t msec);
/* "Lower half" driver methods **********************************************/
-static int max326_start(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_stop(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_keepalive(FAR struct watchdog_lowerhalf_s *lower);
-static int max326_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status);
-static int max326_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int max326_start(struct watchdog_lowerhalf_s *lower);
+static int max326_stop(struct watchdog_lowerhalf_s *lower);
+static int max326_keepalive(struct watchdog_lowerhalf_s *lower);
+static int max326_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status);
+static int max326_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout);
Review Comment:
```suggestion
uint32_t timeout);
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -75,31 +75,31 @@ struct nrf52_adc_s
/* ADC Register access */
-static inline void nrf52_adc_putreg(FAR struct nrf52_adc_s *priv,
+static inline void nrf52_adc_putreg(struct nrf52_adc_s *priv,
uint32_t offset,
uint32_t value);
-static inline uint32_t nrf52_adc_getreg(FAR struct nrf52_adc_s *priv,
+static inline uint32_t nrf52_adc_getreg(struct nrf52_adc_s *priv,
uint32_t offset);
/* ADC helpers */
-static int nrf52_adc_configure(FAR struct nrf52_adc_s *priv);
-static int nrf52_adc_calibrate(FAR struct nrf52_adc_s *priv);
-static uint32_t nrf52_adc_ch_config(FAR struct nrf52_adc_channel_s *cfg);
+static int nrf52_adc_configure(struct nrf52_adc_s *priv);
+static int nrf52_adc_calibrate(struct nrf52_adc_s *priv);
+static uint32_t nrf52_adc_ch_config(struct nrf52_adc_channel_s *cfg);
static uint32_t nrf52_adc_chanpsel(int psel);
-static int nrf52_adc_chancfg(FAR struct nrf52_adc_s *priv, uint8_t chan,
- FAR struct nrf52_adc_channel_s *cfg);
-static int nrf52_adc_isr(int irq, void *context, FAR void *arg);
+static int nrf52_adc_chancfg(struct nrf52_adc_s *priv, uint8_t chan,
+ struct nrf52_adc_channel_s *cfg);
+static int nrf52_adc_isr(int irq, void *context, void *arg);
/* ADC Driver Methods */
-static int nrf52_adc_bind(FAR struct adc_dev_s *dev,
- FAR const struct adc_callback_s *callback);
-static void nrf52_adc_reset(FAR struct adc_dev_s *dev);
-static int nrf52_adc_setup(FAR struct adc_dev_s *dev);
-static void nrf52_adc_shutdown(FAR struct adc_dev_s *dev);
-static void nrf52_adc_rxint(FAR struct adc_dev_s *dev, bool enable);
-static int nrf52_adc_ioctl(FAR struct adc_dev_s *dev, int cmd,
+static int nrf52_adc_bind(struct adc_dev_s *dev,
+ const struct adc_callback_s *callback);
Review Comment:
```suggestion
static int nrf52_adc_bind(struct adc_dev_s *dev,
const struct adc_callback_s *callback);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -238,12 +238,12 @@ static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s
*dev, off_t startblock,
* Name: pplus_fls_read
****************************************************************************/
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
- FAR uint8_t *buffer)
+ uint8_t *buffer)
Review Comment:
```suggestion
uint8_t *buffer)
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -2390,11 +2387,11 @@ static int lpc31_epstall(FAR struct usbdev_ep_s *ep,
bool resume)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *lpc31_allocep(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *lpc31_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *lpc31_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -181,16 +181,16 @@ static inline uint32_t nrf52_adc_getreg(FAR struct
nrf52_adc_s *priv,
*
****************************************************************************/
-static int nrf52_adc_isr(int irq, void *context, FAR void *arg)
+static int nrf52_adc_isr(int irq, void *context, void *arg)
{
- FAR struct adc_dev_s *dev = (FAR struct adc_dev_s *) arg;
- FAR struct nrf52_adc_s *priv = NULL;
+ struct adc_dev_s *dev = (struct adc_dev_s *) arg;
+ struct nrf52_adc_s *priv = NULL;
int ret = OK;
int i = 0;
Review Comment:
```suggestion
int ret = OK;
int i = 0;
```
##########
arch/arm/src/nrf52/nrf52_tim_lowerhalf.c:
##########
@@ -71,14 +71,14 @@ static int nrf52_timer_handler(int irq, void *context, void
*arg);
/* "Lower half" driver methods **********************************************/
-static int nrf52_timer_start(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_stop(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int nrf52_timer_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int nrf52_timer_start(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_stop(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
Review Comment:
```suggestion
static int nrf52_timer_getstatus(struct timer_lowerhalf_s *lower,
struct timer_status_s *status);
```
##########
arch/arm/src/rp2040/rp2040_serial.c:
##########
@@ -643,19 +643,19 @@ static int up_interrupt(int irq, FAR void *context, FAR
void *arg)
*
****************************************************************************/
-static int up_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
+static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
{
- FAR struct inode *inode = filep->f_inode;
- FAR struct uart_dev_s *dev = inode->i_private;
- FAR struct up_dev_s *priv = (FAR struct up_dev_s *)dev->priv;
+ struct inode *inode = filep->f_inode;
+ struct uart_dev_s *dev = inode->i_private;
+ struct up_dev_s *priv = (struct up_dev_s *)dev->priv;
int ret = OK;
Review Comment:
```suggestion
int ret = OK;
```
##########
arch/arm/src/rp2040/rp2040_i2c.c:
##########
@@ -127,21 +127,21 @@ static int rp2040_i2c_disable(struct rp2040_i2cdev_s
*priv);
static void rp2040_i2c_init(struct rp2040_i2cdev_s *priv);
static void rp2040_i2c_enable(struct rp2040_i2cdev_s *priv);
-static int rp2040_i2c_interrupt(int irq, FAR void *context, FAR void *arg);
+static int rp2040_i2c_interrupt(int irq, void *context, void *arg);
static void rp2040_i2c_timeout(wdparm_t arg);
static void rp2040_i2c_setfrequency(struct rp2040_i2cdev_s *priv,
uint32_t frequency);
-static int rp2040_i2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count);
+static int rp2040_i2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count);
Review Comment:
```suggestion
static int rp2040_i2c_transfer(struct i2c_master_s *dev,
struct i2c_msg_s *msgs, int count);
```
##########
arch/arm/src/nrf52/nrf52_adc.c:
##########
@@ -828,9 +828,9 @@ static void nrf52_adc_shutdown(FAR struct adc_dev_s *dev)
*
****************************************************************************/
-static void nrf52_adc_rxint(FAR struct adc_dev_s *dev, bool enable)
+static void nrf52_adc_rxint(struct adc_dev_s *dev, bool enable)
{
- FAR struct nrf52_adc_s *priv = (FAR struct nrf52_adc_s *) dev->ad_priv;
+ struct nrf52_adc_s *priv = (struct nrf52_adc_s *) dev->ad_priv;
uint32_t regval = 0;
Review Comment:
```suggestion
struct nrf52_adc_s *priv = (struct nrf52_adc_s *) dev->ad_priv;
uint32_t regval = 0;
```
##########
arch/arm/src/phy62xx/phyplus_tim.c:
##########
@@ -171,7 +171,7 @@ uint32_t phyplus_tim_getreg32(FAR struct phyplus_tim_dev_s
*dev,
*
****************************************************************************/
-void phyplus_tim_putreg32(FAR struct phyplus_tim_dev_s *dev,
+void phyplus_tim_putreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset,
uint32_t value)
Review Comment:
```suggestion
void phyplus_tim_putreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset,
uint32_t value)
```
##########
arch/arm/src/nrf52/nrf52_tim_lowerhalf.c:
##########
@@ -446,10 +446,10 @@ static void nrf52_timer_setcallback(FAR struct
timer_lowerhalf_s *lower,
*
****************************************************************************/
-int nrf52_timer_initialize(FAR const char *devpath, uint8_t timer)
+int nrf52_timer_initialize(const char *devpath, uint8_t timer)
{
struct nrf52_timer_lowerhalf_s *lower = NULL;
- FAR void *drvr = NULL;
+ void *drvr = NULL;
int ret = OK;
Review Comment:
```suggestion
void *drvr = NULL;
int ret = OK;
```
##########
arch/arm/src/phy62xx/phyplus_gpio.c:
##########
@@ -260,20 +260,20 @@ static int phyplus_gpint_read(FAR struct gpio_dev_s *dev,
FAR bool *value)
}
/* static pin_interrupt_t phyplus_gpint_callback_register
- * (FAR struct gpio_dev_s *dev, uint8_t pin)
+ * (struct gpio_dev_s *dev, uint8_t pin)
* {
* return 0;
* }
*/
-static int phyplus_gpint_attach(FAR struct gpio_dev_s *dev,
+static int phyplus_gpint_attach(struct gpio_dev_s *dev,
pin_interrupt_t callback)
Review Comment:
```suggestion
static int phyplus_gpint_attach(struct gpio_dev_s *dev,
pin_interrupt_t callback)
```
##########
arch/arm/src/phy62xx/phyplus_tim.c:
##########
@@ -188,7 +188,7 @@ void phyplus_tim_putreg32(FAR struct phyplus_tim_dev_s *dev,
*
****************************************************************************/
-void phyplus_tim_modifyreg32(FAR struct phyplus_tim_dev_s *dev,
+void phyplus_tim_modifyreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset,
uint32_t clearbits,
uint32_t setbits)
Review Comment:
```suggestion
void phyplus_tim_modifyreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset,
uint32_t clearbits,
uint32_t setbits)
```
##########
arch/arm/src/phy62xx/phyplus_gpio.c:
##########
@@ -94,13 +94,13 @@ static struct phyplus_gpio_dev_s
g_phyplus_gpio_dev[GPIO_NUM];
* Private Function Prototypes
****************************************************************************/
-static int phyplus_gpin_read(FAR struct gpio_dev_s *dev, FAR bool *value);
-static int phyplus_gpout_read(FAR struct gpio_dev_s *dev, FAR bool *value);
-static int phyplus_gpout_write(FAR struct gpio_dev_s *dev, bool value);
-static int phyplus_gpint_read(FAR struct gpio_dev_s *dev, FAR bool *value);
-static int phyplus_gpint_attach(FAR struct gpio_dev_s *dev,
- FAR pin_interrupt_t callback);
-static int phyplus_gpint_enable(FAR struct gpio_dev_s *dev, bool enable);
+static int phyplus_gpin_read(struct gpio_dev_s *dev, bool *value);
+static int phyplus_gpout_read(struct gpio_dev_s *dev, bool *value);
+static int phyplus_gpout_write(struct gpio_dev_s *dev, bool value);
+static int phyplus_gpint_read(struct gpio_dev_s *dev, bool *value);
+static int phyplus_gpint_attach(struct gpio_dev_s *dev,
+ pin_interrupt_t callback);
Review Comment:
```suggestion
static int phyplus_gpint_attach(struct gpio_dev_s *dev,
pin_interrupt_t callback);
```
##########
arch/arm/src/phy62xx/phyplus_tim.c:
##########
@@ -155,7 +155,7 @@ struct phyplus_tim_priv_s phyplus_tim6_priv =
*
****************************************************************************/
-uint32_t phyplus_tim_getreg32(FAR struct phyplus_tim_dev_s *dev,
+uint32_t phyplus_tim_getreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset)
Review Comment:
```suggestion
uint32_t phyplus_tim_getreg32(struct phyplus_tim_dev_s *dev,
uint32_t offset)
```
##########
arch/arm/src/nrf52/nrf52_tim_lowerhalf.c:
##########
@@ -71,14 +71,14 @@ static int nrf52_timer_handler(int irq, void *context, void
*arg);
/* "Lower half" driver methods **********************************************/
-static int nrf52_timer_start(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_stop(FAR struct timer_lowerhalf_s *lower);
-static int nrf52_timer_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int nrf52_timer_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int nrf52_timer_start(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_stop(struct timer_lowerhalf_s *lower);
+static int nrf52_timer_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int nrf52_timer_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
Review Comment:
```suggestion
static int nrf52_timer_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
```
##########
arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c:
##########
@@ -87,14 +87,14 @@ static int phyplus_timer_handler(int irq, void * context,
void * arg);
/* "Lower half" driver methods **********************************************/
-static int phyplus_start(FAR struct timer_lowerhalf_s *lower);
-static int phyplus_stop(FAR struct timer_lowerhalf_s *lower);
-static int phyplus_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int phyplus_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int phyplus_start(struct timer_lowerhalf_s *lower);
+static int phyplus_stop(struct timer_lowerhalf_s *lower);
+static int phyplus_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int phyplus_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
Review Comment:
```suggestion
static int phyplus_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
```
##########
arch/arm/src/phy62xx/phyplus_wdt.c:
##########
@@ -330,11 +330,11 @@ static int phyplus_wdt_keepalive(FAR struct
watchdog_lowerhalf_s *lower)
*
****************************************************************************/
-static int phyplus_wdt_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status)
+static int phyplus_wdt_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status)
Review Comment:
```suggestion
static int phyplus_wdt_getstatus(struct watchdog_lowerhalf_s *lower,
struct watchdog_status_s *status)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
Review Comment:
```suggestion
static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
```
##########
arch/arm/src/phy62xx/phyplus_wdt.c:
##########
@@ -373,11 +373,11 @@ static int phyplus_wdt_getstatus(FAR struct
watchdog_lowerhalf_s *lower,
*
****************************************************************************/
-static int phyplus_wdt_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int phyplus_wdt_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int phyplus_wdt_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
Review Comment:
```suggestion
static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR const uint8_t *buf);
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+ const uint8_t *buf);
+static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
- FAR uint8_t *buffer);
-static int pplus_fls_ioctl(FAR struct mtd_dev_s *dev,
+ uint8_t *buffer);
Review Comment:
```suggestion
uint8_t *buffer);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
Review Comment:
```suggestion
static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR const uint8_t *buf);
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+ const uint8_t *buf);
Review Comment:
```suggestion
const uint8_t *buf);
```
##########
arch/arm/src/rtl8720c/ameba_flash.c:
##########
@@ -162,12 +162,12 @@ static int ameba_flash_erase(FAR struct mtd_dev_s *dev,
return nblocks;
}
-static ssize_t ameba_flash_bread(FAR struct mtd_dev_s *dev,
+static ssize_t ameba_flash_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
Review Comment:
```suggestion
static ssize_t ameba_flash_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
Review Comment:
```suggestion
static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
```
##########
arch/arm/src/rp2040/rp2040_usbdev.c:
##########
@@ -1816,11 +1816,11 @@ static int rp2040_epstall(FAR struct usbdev_ep_s *ep,
bool resume)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *rp2040_allocep(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *rp2040_allocep(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *rp2040_allocep(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
```
##########
arch/arm/src/rp2040/rp2040_i2c.c:
##########
@@ -532,8 +532,8 @@ static int rp2040_i2c_send(struct rp2040_i2cdev_s *priv,
int last)
* currently guaranteed.
****************************************************************************/
-static int rp2040_i2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count)
+static int rp2040_i2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count)
Review Comment:
```suggestion
static int rp2040_i2c_transfer(struct i2c_master_s *dev,
struct i2c_msg_s *msgs, int count)
```
##########
arch/arm/src/rtl8720c/ameba_flash.c:
##########
@@ -162,12 +162,12 @@ static int ameba_flash_erase(FAR struct mtd_dev_s *dev,
return nblocks;
}
-static ssize_t ameba_flash_bread(FAR struct mtd_dev_s *dev,
+static ssize_t ameba_flash_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf)
+ uint8_t *buf)
Review Comment:
```suggestion
uint8_t *buf)
```
##########
arch/arm/src/rtl8720c/ameba_flash.c:
##########
@@ -317,11 +317,11 @@ static FAR struct mtd_dev_s *ameba_flash_initialize(void)
priv = NULL;
}
- return (FAR struct mtd_dev_s *)priv;
+ return (struct mtd_dev_s *)priv;
}
-static void ameba_partition_init(FAR const struct partition_s *part,
- FAR const void *path)
+static void ameba_partition_init(const struct partition_s *part,
+ const void *path)
Review Comment:
```suggestion
static void ameba_partition_init(const struct partition_s *part,
const void *path)
```
##########
arch/arm/src/s32k1xx/s32k1xx_eeeprom.c:
##########
@@ -201,13 +201,13 @@ static int eeed_close(FAR struct inode *inode)
*
****************************************************************************/
-static ssize_t eeed_read(FAR struct inode *inode, unsigned char *buffer,
+static ssize_t eeed_read(struct inode *inode, unsigned char *buffer,
blkcnt_t start_sector, unsigned int nsectors)
Review Comment:
```suggestion
static ssize_t eeed_read(struct inode *inode, unsigned char *buffer,
blkcnt_t start_sector, unsigned int nsectors)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -67,29 +67,29 @@ struct pplus_fls_dev_s
* Private Function Prototypes
****************************************************************************/
-static int pplus_fls_readid(FAR struct pplus_fls_dev_s *priv);
-static int pplus_fls_erase_sector(FAR struct pplus_fls_dev_s *priv,
+static int pplus_fls_readid(struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_sector(struct pplus_fls_dev_s *priv,
off_t offset);
-static int pplus_fls_erase_chip(FAR struct pplus_fls_dev_s *priv);
+static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv);
/* MTD driver methods */
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks);
-static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_bread(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR uint8_t *buf);
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev,
+ uint8_t *buf);
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks,
- FAR const uint8_t *buf);
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+ const uint8_t *buf);
+static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
- FAR uint8_t *buffer);
-static int pplus_fls_ioctl(FAR struct mtd_dev_s *dev,
+ uint8_t *buffer);
+static int pplus_fls_ioctl(struct mtd_dev_s *dev,
int cmd,
unsigned long arg);
Review Comment:
```suggestion
static int pplus_fls_ioctl(struct mtd_dev_s *dev,
int cmd,
unsigned long arg);
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -209,67 +209,67 @@ struct s32k1xx_lpi2c_priv_s
****************************************************************************/
static inline uint32_t
- s32k1xx_lpi2c_getreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_getreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset);
static inline void
- s32k1xx_lpi2c_putreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_putreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset, uint32_t value);
static inline void
- s32k1xx_lpi2c_modifyreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_modifyreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset, uint32_t clearbits,
uint32_t setbits);
static inline int
- s32k1xx_lpi2c_sem_wait(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_wait(struct s32k1xx_lpi2c_priv_s *priv);
#ifdef CONFIG_S32K1XX_I2C_DYNTIMEO
static useconds_t
- s32k1xx_lpi2c_tousecs(int msgc, FAR struct i2c_msg_s *msgs);
+ s32k1xx_lpi2c_tousecs(int msgc, struct i2c_msg_s *msgs);
#endif /* CONFIG_S32K1XX_I2C_DYNTIMEO */
static inline int
- s32k1xx_lpi2c_sem_waitdone(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_waitdone(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_waitstop(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_waitstop(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_post(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_post(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_init(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_init(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_destroy(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_destroy(struct s32k1xx_lpi2c_priv_s *priv);
#ifdef CONFIG_I2C_TRACE
-static void s32k1xx_lpi2c_tracereset(FAR struct s32k1xx_lpi2c_priv_s *priv);
-static void s32k1xx_lpi2c_tracenew(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_tracereset(struct s32k1xx_lpi2c_priv_s *priv);
+static void s32k1xx_lpi2c_tracenew(struct s32k1xx_lpi2c_priv_s *priv,
uint32_t status);
Review Comment:
```suggestion
uint32_t status);
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -808,7 +808,7 @@ static void s32k1xx_lpi2c_tracereset(FAR struct
s32k1xx_lpi2c_priv_s *priv)
s32k1xx_lpi2c_traceclear(priv);
}
-static void s32k1xx_lpi2c_tracenew(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_tracenew(struct s32k1xx_lpi2c_priv_s *priv,
uint32_t status)
Review Comment:
```suggestion
uint32_t status)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -161,11 +161,11 @@ static int pplus_fls_erase_chip(struct pplus_fls_dev_s
*priv)
* Name: pplus_fls_erase
****************************************************************************/
-static int pplus_fls_erase(FAR struct mtd_dev_s *dev,
+static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks)
Review Comment:
```suggestion
static int pplus_fls_erase(struct mtd_dev_s *dev,
off_t startblock,
size_t nblocks)
```
##########
arch/arm/src/s32k1xx/s32k1xx_enet.c:
##########
@@ -349,8 +349,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev,
bool resetphy);
#ifdef CONFIG_NET_MCASTGROUP
static int s32k1xx_addmac(struct net_driver_s *dev,
- FAR const uint8_t *mac);
-static int s32k1xx_rmmac(struct net_driver_s *dev, FAR const uint8_t *mac);
+ const uint8_t *mac);
Review Comment:
```suggestion
const uint8_t *mac);
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -212,10 +212,10 @@ static ssize_t pplus_fls_bread(FAR struct mtd_dev_s *dev,
off_t startblock,
* Name: pplus_fls_bwrite
****************************************************************************/
-static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s *dev, off_t startblock,
- size_t nblocks, FAR const uint8_t *buffer)
+static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev, off_t startblock,
+ size_t nblocks, const uint8_t *buffer)
Review Comment:
```suggestion
static ssize_t pplus_fls_bwrite(struct mtd_dev_s *dev, off_t startblock,
size_t nblocks, const uint8_t *buffer)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -264,11 +264,11 @@ static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
* Name: pplus_fls_ioctl
****************************************************************************/
-static int pplus_fls_ioctl(FAR struct mtd_dev_s *dev,
+static int pplus_fls_ioctl(struct mtd_dev_s *dev,
int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int pplus_fls_ioctl(struct mtd_dev_s *dev,
int cmd,
unsigned long arg)
```
##########
arch/arm/src/phy62xx/pplus_mtd_flash.c:
##########
@@ -238,12 +238,12 @@ static ssize_t pplus_fls_bwrite(FAR struct mtd_dev_s
*dev, off_t startblock,
* Name: pplus_fls_read
****************************************************************************/
-static ssize_t pplus_fls_read(FAR struct mtd_dev_s *dev,
+static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
Review Comment:
```suggestion
static ssize_t pplus_fls_read(struct mtd_dev_s *dev,
off_t offset,
size_t nbytes,
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -209,67 +209,67 @@ struct s32k1xx_lpi2c_priv_s
****************************************************************************/
static inline uint32_t
- s32k1xx_lpi2c_getreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_getreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset);
static inline void
- s32k1xx_lpi2c_putreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_putreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset, uint32_t value);
static inline void
- s32k1xx_lpi2c_modifyreg(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_modifyreg(struct s32k1xx_lpi2c_priv_s *priv,
uint16_t offset, uint32_t clearbits,
uint32_t setbits);
static inline int
- s32k1xx_lpi2c_sem_wait(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_wait(struct s32k1xx_lpi2c_priv_s *priv);
#ifdef CONFIG_S32K1XX_I2C_DYNTIMEO
static useconds_t
- s32k1xx_lpi2c_tousecs(int msgc, FAR struct i2c_msg_s *msgs);
+ s32k1xx_lpi2c_tousecs(int msgc, struct i2c_msg_s *msgs);
#endif /* CONFIG_S32K1XX_I2C_DYNTIMEO */
static inline int
- s32k1xx_lpi2c_sem_waitdone(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_waitdone(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_waitstop(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_waitstop(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_post(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_post(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_init(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_init(struct s32k1xx_lpi2c_priv_s *priv);
static inline void
- s32k1xx_lpi2c_sem_destroy(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sem_destroy(struct s32k1xx_lpi2c_priv_s *priv);
#ifdef CONFIG_I2C_TRACE
-static void s32k1xx_lpi2c_tracereset(FAR struct s32k1xx_lpi2c_priv_s *priv);
-static void s32k1xx_lpi2c_tracenew(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_tracereset(struct s32k1xx_lpi2c_priv_s *priv);
+static void s32k1xx_lpi2c_tracenew(struct s32k1xx_lpi2c_priv_s *priv,
uint32_t status);
-static void s32k1xx_lpi2c_traceevent(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_traceevent(struct s32k1xx_lpi2c_priv_s *priv,
enum s32k1xx_trace_e event,
uint32_t parm);
-static void s32k1xx_lpi2c_tracedump(FAR struct s32k1xx_lpi2c_priv_s *priv);
+static void s32k1xx_lpi2c_tracedump(struct s32k1xx_lpi2c_priv_s *priv);
#endif /* CONFIG_I2C_TRACE */
static uint32_t s32k1xx_lpi2c_pckfreq(uintptr_t base);
-static void s32k1xx_lpi2c_setclock(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_setclock(struct s32k1xx_lpi2c_priv_s *priv,
uint32_t frequency);
static inline void
- s32k1xx_lpi2c_sendstart(FAR struct s32k1xx_lpi2c_priv_s *priv,
+ s32k1xx_lpi2c_sendstart(struct s32k1xx_lpi2c_priv_s *priv,
uint8_t address);
static inline void
- s32k1xx_lpi2c_sendstop(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_sendstop(struct s32k1xx_lpi2c_priv_s *priv);
static inline uint32_t
- s32k1xx_lpi2c_getstatus(FAR struct s32k1xx_lpi2c_priv_s *priv);
+ s32k1xx_lpi2c_getstatus(struct s32k1xx_lpi2c_priv_s *priv);
static int s32k1xx_lpi2c_isr_process(struct s32k1xx_lpi2c_priv_s *priv);
#ifndef CONFIG_I2C_POLLED
-static int s32k1xx_lpi2c_isr(int irq, void *context, FAR void *arg);
+static int s32k1xx_lpi2c_isr(int irq, void *context, void *arg);
#endif /* !CONFIG_I2C_POLLED */
-static int s32k1xx_lpi2c_init(FAR struct s32k1xx_lpi2c_priv_s *priv);
-static int s32k1xx_lpi2c_deinit(FAR struct s32k1xx_lpi2c_priv_s *priv);
-static int s32k1xx_lpi2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count);
+static int s32k1xx_lpi2c_init(struct s32k1xx_lpi2c_priv_s *priv);
+static int s32k1xx_lpi2c_deinit(struct s32k1xx_lpi2c_priv_s *priv);
+static int s32k1xx_lpi2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count);
Review Comment:
```suggestion
struct i2c_msg_s *msgs, int count);
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -1522,10 +1522,10 @@ static int s32k1xx_lpi2c_deinit(FAR struct
s32k1xx_lpi2c_priv_s *priv)
*
****************************************************************************/
-static int s32k1xx_lpi2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count)
+static int s32k1xx_lpi2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count)
Review Comment:
```suggestion
struct i2c_msg_s *msgs, int count)
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -956,7 +956,7 @@ static uint32_t s32k1xx_lpi2c_pckfreq(uintptr_t base)
*
****************************************************************************/
-static void s32k1xx_lpi2c_setclock(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_setclock(struct s32k1xx_lpi2c_priv_s *priv,
uint32_t frequency)
Review Comment:
```suggestion
uint32_t frequency)
```
##########
arch/arm/src/rtl8720c/amebaz_hci_board.h:
##########
@@ -45,9 +45,9 @@
int hci_check_iqk(void);
int hci_start_iqk(void);
-int hci_set_init_config_mac(FAR uint8_t *addr, uint8_t diffvalue);
-int hci_get_baudrate(FAR uint32_t *bt_baudrate,
- FAR uint32_t *uart_baudrate);
+int hci_set_init_config_mac(uint8_t *addr, uint8_t diffvalue);
+int hci_get_baudrate(uint32_t *bt_baudrate,
+ uint32_t *uart_baudrate);
Review Comment:
```suggestion
int hci_get_baudrate(uint32_t *bt_baudrate,
uint32_t *uart_baudrate);
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpspi.c:
##########
@@ -670,7 +670,7 @@ static inline uint16_t s32k1xx_lpspi_9to16bitmode(
*
****************************************************************************/
-static void s32k1xx_lpspi_modifyreg32(FAR struct s32k1xx_lpspidev_s *priv,
+static void s32k1xx_lpspi_modifyreg32(struct s32k1xx_lpspidev_s *priv,
uint8_t offset, uint32_t clrbits,
uint32_t setbits)
Review Comment:
```suggestion
uint32_t setbits)
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpspi.c:
##########
@@ -1024,10 +1024,10 @@ static void s32k1xx_lpspi_select(FAR struct spi_dev_s
*dev, uint32_t devid,
*
****************************************************************************/
-static uint32_t s32k1xx_lpspi_setfrequency(FAR struct spi_dev_s *dev,
+static uint32_t s32k1xx_lpspi_setfrequency(struct spi_dev_s *dev,
uint32_t frequency)
Review Comment:
```suggestion
uint32_t frequency)
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpspi.c:
##########
@@ -1739,8 +1739,8 @@ static void s32k1xx_lpspi_exchange_nodma(FAR struct
spi_dev_s *dev,
****************************************************************************/
#ifndef CONFIG_SPI_EXCHANGE
-static void s32k1xx_lpspi_sndblock(FAR struct spi_dev_s *dev,
- FAR const void *txbuffer, size_t nwords)
+static void s32k1xx_lpspi_sndblock(struct spi_dev_s *dev,
+ const void *txbuffer, size_t nwords)
Review Comment:
```suggestion
const void *txbuffer, size_t nwords)
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpi2c.c:
##########
@@ -848,7 +848,7 @@ static void s32k1xx_lpi2c_tracenew(FAR struct
s32k1xx_lpi2c_priv_s *priv,
}
}
-static void s32k1xx_lpi2c_traceevent(FAR struct s32k1xx_lpi2c_priv_s *priv,
+static void s32k1xx_lpi2c_traceevent(struct s32k1xx_lpi2c_priv_s *priv,
enum s32k1xx_trace_e event, uint32_t parm)
Review Comment:
```suggestion
static void s32k1xx_lpi2c_traceevent(struct s32k1xx_lpi2c_priv_s *priv,
enum s32k1xx_trace_e event,
uint32_t parm)
```
##########
arch/arm/src/s32k1xx/s32k1xx_lpspi.c:
##########
@@ -1461,17 +1461,17 @@ static uint32_t s32k1xx_lpspi_send_dword(FAR struct
spi_dev_s *dev,
#if !defined(CONFIG_S32K1XX_LPSPI_DMA) || defined(CONFIG_S32K1XX_DMACAPABLE)
#if !defined(CONFIG_S32K1XX_LPSPI_DMA)
-static void s32k1xx_lpspi_exchange(FAR struct spi_dev_s *dev,
- FAR const void *txbuffer,
- FAR void *rxbuffer,
+static void s32k1xx_lpspi_exchange(struct spi_dev_s *dev,
+ const void *txbuffer,
+ void *rxbuffer,
size_t nwords)
#else
-static void s32k1xx_lpspi_exchange_nodma(FAR struct spi_dev_s *dev,
- FAR const void *txbuffer,
- FAR void *rxbuffer, size_t nwords)
+static void s32k1xx_lpspi_exchange_nodma(struct spi_dev_s *dev,
+ const void *txbuffer,
+ void *rxbuffer, size_t nwords)
Review Comment:
```suggestion
static void s32k1xx_lpspi_exchange_nodma(struct spi_dev_s *dev,
const void *txbuffer,
void *rxbuffer, size_t nwords)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
