pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r861510798
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_usbhost.c:
##########
@@ -2141,8 +2141,8 @@ static int lpc17_40_rh_enumerate(struct
usbhost_connection_s *conn,
return OK;
}
-static int lpc17_40_enumerate(FAR struct usbhost_connection_s *conn,
- FAR struct usbhost_hubport_s *hport)
+static int lpc17_40_enumerate(struct usbhost_connection_s *conn,
+ struct usbhost_hubport_s *hport)
Review Comment:
```suggestion
static int lpc17_40_enumerate(struct usbhost_connection_s *conn,
struct usbhost_hubport_s *hport)
```
##########
boards/arm/xmc4/xmc4500-relax/src/xmc4_spi.c:
##########
@@ -159,7 +159,7 @@ void xmc4_spi2select(FAR struct spi_dev_s *dev, uint32_t
devid,
#endif
#ifdef CONFIG_XMC4_SPI3
-void xmc4_spi3select(FAR struct spi_dev_s *dev, uint32_t devid,
+void xmc4_spi3select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void xmc4_spi3select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
boards/arm/xmc4/xmc4500-relax/src/xmc4_spi.c:
##########
@@ -134,7 +134,7 @@ void xmc4_spi0select(FAR struct spi_dev_s *dev, uint32_t
devid,
#endif
#ifdef CONFIG_XMC4_SPI1
-void xmc4_spi1select(FAR struct spi_dev_s *dev, uint32_t devid,
+void xmc4_spi1select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void xmc4_spi1select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
arch/arm/src/lpc54xx/lpc54_lcd.c:
##########
@@ -352,8 +352,8 @@ static int lpc54_putcmap(FAR struct fb_vtable_s *vtable,
****************************************************************************/
#ifdef CONFIG_FB_HWCURSOR
-static int lpc54_getcursor(FAR struct fb_vtable_s *vtable,
- FAR struct fb_cursorattrib_s *attrib)
+static int lpc54_getcursor(struct fb_vtable_s *vtable,
+ struct fb_cursorattrib_s *attrib)
Review Comment:
```suggestion
static int lpc54_getcursor(struct fb_vtable_s *vtable,
struct fb_cursorattrib_s *attrib)
```
##########
boards/arm/tms570/tms570ls31x-usb-kit/src/tms570_spi.c:
##########
@@ -118,7 +118,7 @@ uint8_t tms570_spi1status(FAR struct spi_dev_s *dev,
uint32_t devid)
#endif
#ifdef CONFIG_TMS570_SPI4
-void tms570_spi4select(FAR struct spi_dev_s *dev, uint32_t devid,
+void tms570_spi4select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void tms570_spi4select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
boards/arm/tms570/tms570ls31x-usb-kit/src/tms570_spi.c:
##########
@@ -91,7 +91,7 @@ void tms570_spidev_initialize(void)
****************************************************************************/
#ifdef CONFIG_TMS570_SPI1
-void tms570_spi1select(FAR struct spi_dev_s *dev, uint32_t devid,
+void tms570_spi1select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void tms570_spi1select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
boards/arm/xmc4/xmc4500-relax/src/xmc4_spi.c:
##########
@@ -125,7 +125,7 @@ void weak_function xmc4_spidev_initialize(void)
****************************************************************************/
#ifdef CONFIG_XMC4_SPI0
-void xmc4_spi0select(FAR struct spi_dev_s *dev, uint32_t devid,
+void xmc4_spi0select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void xmc4_spi0select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
boards/arm/xmc4/xmc4500-relax/src/xmc4_spi.c:
##########
@@ -143,7 +143,7 @@ void xmc4_spi1select(FAR struct spi_dev_s *dev, uint32_t
devid,
#endif
#ifdef CONFIG_XMC4_SPI2
-void xmc4_spi2select(FAR struct spi_dev_s *dev, uint32_t devid,
+void xmc4_spi2select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
Review Comment:
```suggestion
void xmc4_spi2select(struct spi_dev_s *dev, uint32_t devid,
bool selected)
```
##########
boards/arm/stm32l4/nucleo-l476rg/src/stm32_ajoystick.c:
##########
@@ -100,17 +100,17 @@
****************************************************************************/
static ajoy_buttonset_t
-ajoy_supported(FAR const struct ajoy_lowerhalf_s *lower);
-static int ajoy_sample(FAR const struct ajoy_lowerhalf_s *lower,
- FAR struct ajoy_sample_s *sample);
+ajoy_supported(const struct ajoy_lowerhalf_s *lower);
+static int ajoy_sample(const struct ajoy_lowerhalf_s *lower,
+ struct ajoy_sample_s *sample);
static ajoy_buttonset_t
-ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower);
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+ajoy_buttons(const struct ajoy_lowerhalf_s *lower);
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
- ajoy_handler_t handler, FAR void *arg);
+ ajoy_handler_t handler, void *arg);
Review Comment:
```suggestion
ajoy_handler_t handler, void *arg);
```
##########
boards/arm/stm32l4/nucleo-l476rg/src/stm32_ajoystick.c:
##########
@@ -100,17 +100,17 @@
****************************************************************************/
static ajoy_buttonset_t
-ajoy_supported(FAR const struct ajoy_lowerhalf_s *lower);
-static int ajoy_sample(FAR const struct ajoy_lowerhalf_s *lower,
- FAR struct ajoy_sample_s *sample);
+ajoy_supported(const struct ajoy_lowerhalf_s *lower);
+static int ajoy_sample(const struct ajoy_lowerhalf_s *lower,
+ struct ajoy_sample_s *sample);
static ajoy_buttonset_t
-ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower);
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+ajoy_buttons(const struct ajoy_lowerhalf_s *lower);
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
Review Comment:
```suggestion
ajoy_buttonset_t press, ajoy_buttonset_t release,
```
##########
boards/arm/stm32l4/nucleo-l476rg/src/stm32_ajoystick.c:
##########
@@ -315,9 +315,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
- ajoy_handler_t handler, FAR void *arg)
+ ajoy_handler_t handler, void *arg)
Review Comment:
```suggestion
ajoy_handler_t handler, void *arg)
```
##########
boards/arm/stm32l4/nucleo-l476rg/src/stm32_ajoystick.c:
##########
@@ -315,9 +315,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
Review Comment:
```suggestion
ajoy_buttonset_t press, ajoy_buttonset_t release,
```
##########
boards/arm/str71x/olimex-strp711/src/str71_spi.c:
##########
@@ -377,29 +377,29 @@ struct str71x_spidev_s
/* Helpers */
-static inline uint16_t spi_getreg(FAR struct str71x_spidev_s *priv,
+static inline uint16_t spi_getreg(struct str71x_spidev_s *priv,
uint8_t offset);
-static inline void spi_putreg(FAR struct str71x_spidev_s *priv,
+static inline void spi_putreg(struct str71x_spidev_s *priv,
uint8_t offset, uint16_t value);
-static inline void spi_drain(FAR struct str71x_spidev_s *priv);
+static inline void spi_drain(struct str71x_spidev_s *priv);
/* SPI methods */
-static int spi_lock(FAR struct spi_dev_s *dev, bool lock);
-static void spi_select(FAR struct spi_dev_s *dev, uint32_t devid,
+static int spi_lock(struct spi_dev_s *dev, bool lock);
+static void spi_select(struct spi_dev_s *dev, uint32_t devid,
bool selected);
-static uint32_t spi_setfrequency(FAR struct spi_dev_s *dev,
+static uint32_t spi_setfrequency(struct spi_dev_s *dev,
uint32_t frequency);
Review Comment:
```suggestion
static uint32_t spi_setfrequency(struct spi_dev_s *dev,
uint32_t frequency);
```
##########
boards/arm/stm32l4/b-l475e-iot01a/src/stm32_spirit.c:
##########
@@ -81,12 +81,12 @@ struct stm32l4_priv_s
* stm32l4_enable_irq - Enable or disable the GPIO interrupt
*/
-static int stm32l4_reset(FAR const struct spirit_lower_s *lower);
-static int stm32l4_attach_irq(FAR const struct spirit_lower_s *lower,
- xcpt_t handler, FAR void *arg);
-static void stm32l4_enable_irq(FAR const struct spirit_lower_s *lower,
+static int stm32l4_reset(const struct spirit_lower_s *lower);
+static int stm32l4_attach_irq(const struct spirit_lower_s *lower,
+ xcpt_t handler, void *arg);
+static void stm32l4_enable_irq(const struct spirit_lower_s *lower,
bool state);
Review Comment:
```suggestion
static void stm32l4_enable_irq(const struct spirit_lower_s *lower,
bool state);
```
##########
boards/arm/stm32l4/b-l475e-iot01a/src/stm32_spirit.c:
##########
@@ -148,10 +148,10 @@ static int stm32l4_reset(FAR const struct spirit_lower_s
*lower)
* stm32l4_enable_irq - Enable or disable the GPIO interrupt
*/
-static int stm32l4_attach_irq(FAR const struct spirit_lower_s *lower,
- xcpt_t handler, FAR void *arg)
+static int stm32l4_attach_irq(const struct spirit_lower_s *lower,
+ xcpt_t handler, void *arg)
Review Comment:
```suggestion
static int stm32l4_attach_irq(const struct spirit_lower_s *lower,
xcpt_t handler, void *arg)
```
##########
boards/arm/stm32l4/b-l475e-iot01a/src/stm32_spirit.c:
##########
@@ -81,12 +81,12 @@ struct stm32l4_priv_s
* stm32l4_enable_irq - Enable or disable the GPIO interrupt
*/
-static int stm32l4_reset(FAR const struct spirit_lower_s *lower);
-static int stm32l4_attach_irq(FAR const struct spirit_lower_s *lower,
- xcpt_t handler, FAR void *arg);
-static void stm32l4_enable_irq(FAR const struct spirit_lower_s *lower,
+static int stm32l4_reset(const struct spirit_lower_s *lower);
+static int stm32l4_attach_irq(const struct spirit_lower_s *lower,
+ xcpt_t handler, void *arg);
Review Comment:
```suggestion
static int stm32l4_attach_irq(const struct spirit_lower_s *lower,
xcpt_t handler, void *arg);
```
##########
boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:
##########
@@ -1495,7 +1495,7 @@ static int slcd_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
* Name: slcd_poll
****************************************************************************/
-static int slcd_poll(FAR struct file *filep, FAR struct pollfd *fds,
+static int slcd_poll(struct file *filep, struct pollfd *fds,
bool setup)
Review Comment:
```suggestion
static int slcd_poll(struct file *filep, struct pollfd *fds,
bool setup)
```
##########
boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c:
##########
@@ -63,22 +63,22 @@ struct stm32_mwinfo_s
* Private Functions
****************************************************************************/
-static int wm8994_attach(FAR const struct wm8994_lower_s *lower,
- wm8994_handler_t isr, FAR void *arg)
+static int wm8994_attach(const struct wm8994_lower_s *lower,
+ wm8994_handler_t isr, void *arg)
{
audinfo("TODO\n");
return 0;
}
-static bool wm8994_enable(FAR const struct wm8994_lower_s *lower,
+static bool wm8994_enable(const struct wm8994_lower_s *lower,
bool enable)
Review Comment:
```suggestion
static bool wm8994_enable(const struct wm8994_lower_s *lower,
bool enable)
```
##########
boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c:
##########
@@ -63,22 +63,22 @@ struct stm32_mwinfo_s
* Private Functions
****************************************************************************/
-static int wm8994_attach(FAR const struct wm8994_lower_s *lower,
- wm8994_handler_t isr, FAR void *arg)
+static int wm8994_attach(const struct wm8994_lower_s *lower,
+ wm8994_handler_t isr, void *arg)
Review Comment:
```suggestion
static int wm8994_attach(const struct wm8994_lower_s *lower,
wm8994_handler_t isr, void *arg)
```
##########
boards/arm/stm32f7/stm32f746g-disco/src/stm32_n25q.c:
##########
@@ -75,8 +75,8 @@
int stm32_n25qxxx_setup(void)
{
- FAR struct qspi_dev_s *qspi_dev ;
- FAR struct mtd_dev_s *mtd_dev;
+ struct qspi_dev_s *qspi_dev ;
Review Comment:
```suggestion
struct qspi_dev_s *qspi_dev;
```
##########
boards/arm/stm32/stm32f4discovery/src/stm32_gs2200m.c:
##########
@@ -74,12 +74,12 @@ static const struct gs2200m_lower_s g_wifi_lower =
.reset = gs2200m_reset
};
-static FAR void *g_devhandle = NULL;
+static void *g_devhandle = NULL;
static volatile int32_t _enable_count = 0;
static volatile uint32_t _n_called;
static xcpt_t g_irq_handler = NULL;
Review Comment:
```suggestion
static xcpt_t g_irq_handler = NULL;
```
##########
boards/arm/stm32/stm32f429i-disco/src/stm32_ili93414ws.c:
##########
@@ -1083,10 +1083,10 @@ static int stm32_ili93414ws_sendgram(FAR struct
ili9341_lcd_s *lcd,
*
****************************************************************************/
-static int stm32_ili93414ws_recvparam(FAR struct ili9341_lcd_s *lcd,
+static int stm32_ili93414ws_recvparam(struct ili9341_lcd_s *lcd,
uint8_t *param)
Review Comment:
```suggestion
uint8_t *param)
```
##########
boards/arm/stm32/stm32f429i-disco/src/stm32_ili93414ws.c:
##########
@@ -1114,10 +1114,10 @@ static int stm32_ili93414ws_recvparam(FAR struct
ili9341_lcd_s *lcd,
*
****************************************************************************/
-static int stm32_ili93414ws_recvgram(FAR struct ili9341_lcd_s *lcd,
+static int stm32_ili93414ws_recvgram(struct ili9341_lcd_s *lcd,
uint16_t *wd, uint32_t nwords)
Review Comment:
```suggestion
uint16_t *wd, uint32_t nwords)
```
##########
boards/arm/stm32/stm32f429i-disco/src/stm32_ili93414ws.c:
##########
@@ -1054,10 +1054,10 @@ static int stm32_ili93414ws_sendparam(FAR struct
ili9341_lcd_s *lcd,
*
****************************************************************************/
-static int stm32_ili93414ws_sendgram(FAR struct ili9341_lcd_s *lcd,
+static int stm32_ili93414ws_sendgram(struct ili9341_lcd_s *lcd,
const uint16_t *wd, uint32_t nwords)
Review Comment:
```suggestion
static int stm32_ili93414ws_sendgram(struct ili9341_lcd_s *lcd,
const uint16_t *wd, uint32_t nwords)
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_smps.c:
##########
@@ -344,13 +344,13 @@ static int smps_shutdown(FAR struct smps_dev_s *dev)
*
****************************************************************************/
-static int smps_setup(FAR struct smps_dev_s *dev)
+static int smps_setup(struct smps_dev_s *dev)
{
- FAR struct smps_lower_dev_s *lower = dev->lower;
- FAR struct smps_s *smps = (FAR struct smps_s *)dev->priv;
- FAR struct hrtim_dev_s *hrtim = NULL;
- FAR struct stm32_adc_dev_s *adc = NULL;
- FAR struct smps_priv_s *priv;
+ struct smps_lower_dev_s *lower = dev->lower;
+ struct smps_s *smps = (struct smps_s *)dev->priv;
+ struct hrtim_dev_s *hrtim = NULL;
+ struct stm32_adc_dev_s *adc = NULL;
+ struct smps_priv_s *priv;
struct adc_channel_s channels[ADC1_NCHANNELS];
struct adc_sample_time_s stime;
Review Comment:
```suggestion
struct adc_channel_s channels[ADC1_NCHANNELS];
struct adc_sample_time_s stime;
```
##########
boards/arm/stm32/stm32f429i-disco/src/stm32_ili93414ws.c:
##########
@@ -1024,10 +1024,10 @@ static int stm32_ili93414ws_sendcmd(
*
****************************************************************************/
-static int stm32_ili93414ws_sendparam(FAR struct ili9341_lcd_s *lcd,
+static int stm32_ili93414ws_sendparam(struct ili9341_lcd_s *lcd,
const uint8_t param)
Review Comment:
```suggestion
const uint8_t param)
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_smps.c:
##########
@@ -1052,10 +1052,10 @@ static void adc12_handler(void)
int stm32_smps_setup(void)
{
- FAR struct smps_lower_dev_s *lower = &g_smps_lower;
- FAR struct smps_dev_s *smps = &g_smps_dev;
- FAR struct hrtim_dev_s *hrtim = NULL;
- FAR struct adc_dev_s *adc = NULL;
+ struct smps_lower_dev_s *lower = &g_smps_lower;
+ struct smps_dev_s *smps = &g_smps_dev;
+ struct hrtim_dev_s *hrtim = NULL;
+ struct adc_dev_s *adc = NULL;
static bool initialized = false;
int ret = OK;
Review Comment:
```suggestion
static bool initialized = false;
int ret = OK;
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_smps.c:
##########
@@ -219,23 +219,23 @@ struct smps_priv_s
* Private Function Protototypes
****************************************************************************/
-static int smps_setup(FAR struct smps_dev_s *dev);
-static int smps_shutdown(FAR struct smps_dev_s *dev);
-static int smps_start(FAR struct smps_dev_s *dev);
-static int smps_stop(FAR struct smps_dev_s *dev);
-static int smps_params_set(FAR struct smps_dev_s *dev,
- FAR struct smps_params_s *param);
-static int smps_mode_set(FAR struct smps_dev_s *dev, uint8_t mode);
-static int smps_limits_set(FAR struct smps_dev_s *dev,
- FAR struct smps_limits_s *limits);
-static int smps_state_get(FAR struct smps_dev_s *dev,
- FAR struct smps_state_s *state);
-static int smps_fault_set(FAR struct smps_dev_s *dev, uint8_t fault);
-static int smps_fault_get(FAR struct smps_dev_s *dev,
- FAR uint8_t *fault);
-static int smps_fault_clean(FAR struct smps_dev_s *dev,
+static int smps_setup(struct smps_dev_s *dev);
+static int smps_shutdown(struct smps_dev_s *dev);
+static int smps_start(struct smps_dev_s *dev);
+static int smps_stop(struct smps_dev_s *dev);
+static int smps_params_set(struct smps_dev_s *dev,
+ struct smps_params_s *param);
+static int smps_mode_set(struct smps_dev_s *dev, uint8_t mode);
+static int smps_limits_set(struct smps_dev_s *dev,
+ struct smps_limits_s *limits);
+static int smps_state_get(struct smps_dev_s *dev,
+ struct smps_state_s *state);
+static int smps_fault_set(struct smps_dev_s *dev, uint8_t fault);
+static int smps_fault_get(struct smps_dev_s *dev,
+ uint8_t *fault);
+static int smps_fault_clean(struct smps_dev_s *dev,
uint8_t fault);
Review Comment:
```suggestion
static int smps_fault_clean(struct smps_dev_s *dev,
uint8_t fault);
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_smps.c:
##########
@@ -219,23 +219,23 @@ struct smps_priv_s
* Private Function Protototypes
****************************************************************************/
-static int smps_setup(FAR struct smps_dev_s *dev);
-static int smps_shutdown(FAR struct smps_dev_s *dev);
-static int smps_start(FAR struct smps_dev_s *dev);
-static int smps_stop(FAR struct smps_dev_s *dev);
-static int smps_params_set(FAR struct smps_dev_s *dev,
- FAR struct smps_params_s *param);
-static int smps_mode_set(FAR struct smps_dev_s *dev, uint8_t mode);
-static int smps_limits_set(FAR struct smps_dev_s *dev,
- FAR struct smps_limits_s *limits);
-static int smps_state_get(FAR struct smps_dev_s *dev,
- FAR struct smps_state_s *state);
-static int smps_fault_set(FAR struct smps_dev_s *dev, uint8_t fault);
-static int smps_fault_get(FAR struct smps_dev_s *dev,
- FAR uint8_t *fault);
-static int smps_fault_clean(FAR struct smps_dev_s *dev,
+static int smps_setup(struct smps_dev_s *dev);
+static int smps_shutdown(struct smps_dev_s *dev);
+static int smps_start(struct smps_dev_s *dev);
+static int smps_stop(struct smps_dev_s *dev);
+static int smps_params_set(struct smps_dev_s *dev,
+ struct smps_params_s *param);
+static int smps_mode_set(struct smps_dev_s *dev, uint8_t mode);
+static int smps_limits_set(struct smps_dev_s *dev,
+ struct smps_limits_s *limits);
+static int smps_state_get(struct smps_dev_s *dev,
+ struct smps_state_s *state);
+static int smps_fault_set(struct smps_dev_s *dev, uint8_t fault);
+static int smps_fault_get(struct smps_dev_s *dev,
+ uint8_t *fault);
Review Comment:
```suggestion
static int smps_fault_get(struct smps_dev_s *dev,
uint8_t *fault);
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_smps.c:
##########
@@ -219,23 +219,23 @@ struct smps_priv_s
* Private Function Protototypes
****************************************************************************/
-static int smps_setup(FAR struct smps_dev_s *dev);
-static int smps_shutdown(FAR struct smps_dev_s *dev);
-static int smps_start(FAR struct smps_dev_s *dev);
-static int smps_stop(FAR struct smps_dev_s *dev);
-static int smps_params_set(FAR struct smps_dev_s *dev,
- FAR struct smps_params_s *param);
-static int smps_mode_set(FAR struct smps_dev_s *dev, uint8_t mode);
-static int smps_limits_set(FAR struct smps_dev_s *dev,
- FAR struct smps_limits_s *limits);
-static int smps_state_get(FAR struct smps_dev_s *dev,
- FAR struct smps_state_s *state);
-static int smps_fault_set(FAR struct smps_dev_s *dev, uint8_t fault);
-static int smps_fault_get(FAR struct smps_dev_s *dev,
- FAR uint8_t *fault);
-static int smps_fault_clean(FAR struct smps_dev_s *dev,
+static int smps_setup(struct smps_dev_s *dev);
+static int smps_shutdown(struct smps_dev_s *dev);
+static int smps_start(struct smps_dev_s *dev);
+static int smps_stop(struct smps_dev_s *dev);
+static int smps_params_set(struct smps_dev_s *dev,
+ struct smps_params_s *param);
+static int smps_mode_set(struct smps_dev_s *dev, uint8_t mode);
+static int smps_limits_set(struct smps_dev_s *dev,
+ struct smps_limits_s *limits);
+static int smps_state_get(struct smps_dev_s *dev,
+ struct smps_state_s *state);
+static int smps_fault_set(struct smps_dev_s *dev, uint8_t fault);
+static int smps_fault_get(struct smps_dev_s *dev,
+ uint8_t *fault);
+static int smps_fault_clean(struct smps_dev_s *dev,
uint8_t fault);
-static int smps_ioctl(FAR struct smps_dev_s *dev, int cmd,
+static int smps_ioctl(struct smps_dev_s *dev, int cmd,
unsigned long arg);
Review Comment:
```suggestion
static int smps_ioctl(struct smps_dev_s *dev, int cmd,
unsigned long arg);
```
##########
boards/arm/stm32/stm3210e-eval/src/stm32_lcd.c:
##########
@@ -933,8 +933,8 @@ static int stm3210e_getrun(fb_coord_t row, fb_coord_t col,
*
****************************************************************************/
-static int stm3210e_getvideoinfo(FAR struct lcd_dev_s *dev,
- FAR struct fb_videoinfo_s *vinfo)
+static int stm3210e_getvideoinfo(struct lcd_dev_s *dev,
+ struct fb_videoinfo_s *vinfo)
Review Comment:
```suggestion
static int stm3210e_getvideoinfo(struct lcd_dev_s *dev,
struct fb_videoinfo_s *vinfo)
```
##########
boards/arm/stm32/stm3210e-eval/src/stm32_djoystick.c:
##########
@@ -59,15 +59,15 @@
****************************************************************************/
static djoy_buttonset_t
-djoy_supported(FAR const struct djoy_lowerhalf_s *lower);
+djoy_supported(const struct djoy_lowerhalf_s *lower);
static djoy_buttonset_t
-djoy_sample(FAR const struct djoy_lowerhalf_s *lower);
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+djoy_sample(const struct djoy_lowerhalf_s *lower);
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
Review Comment:
```suggestion
djoy_buttonset_t press, djoy_buttonset_t release,
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_powerled.c:
##########
@@ -502,40 +502,40 @@ static int powerled_limits_set(FAR struct powerled_dev_s
*dev,
return ret;
}
-static int powerled_state_get(FAR struct powerled_dev_s *dev,
- FAR struct powerled_state_s *state)
+static int powerled_state_get(struct powerled_dev_s *dev,
+ struct powerled_state_s *state)
Review Comment:
```suggestion
static int powerled_state_get(struct powerled_dev_s *dev,
struct powerled_state_s *state)
```
##########
boards/arm/stm32/stm32f334-disco/src/stm32_powerled.c:
##########
@@ -562,11 +562,11 @@ static int powerled_ioctl(FAR struct powerled_dev_s *dev,
int cmd,
int stm32_powerled_setup(void)
{
- FAR struct powerled_lower_dev_s *lower = &g_powerled_lower;
- FAR struct powerled_dev_s *powerled = &g_powerled_dev;
- FAR struct hrtim_dev_s *hrtim = NULL;
- FAR struct comp_dev_s *comp = NULL;
- FAR struct dac_dev_s *dac = NULL;
+ struct powerled_lower_dev_s *lower = &g_powerled_lower;
+ struct powerled_dev_s *powerled = &g_powerled_dev;
+ struct hrtim_dev_s *hrtim = NULL;
+ struct comp_dev_s *comp = NULL;
+ struct dac_dev_s *dac = NULL;
static bool initialized = false;
int ret = OK;
Review Comment:
```suggestion
static bool initialized = false;
int ret = OK;
```
##########
boards/arm/stm32/stm3210e-eval/src/stm32_djoystick.c:
##########
@@ -59,15 +59,15 @@
****************************************************************************/
static djoy_buttonset_t
-djoy_supported(FAR const struct djoy_lowerhalf_s *lower);
+djoy_supported(const struct djoy_lowerhalf_s *lower);
static djoy_buttonset_t
-djoy_sample(FAR const struct djoy_lowerhalf_s *lower);
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+djoy_sample(const struct djoy_lowerhalf_s *lower);
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
- djoy_interrupt_t handler, FAR void *arg);
+ djoy_interrupt_t handler, void *arg);
Review Comment:
```suggestion
djoy_interrupt_t handler, void *arg);
```
##########
boards/arm/stm32/stm3210e-eval/src/stm32_djoystick.c:
##########
@@ -152,9 +152,9 @@ static djoy_buttonset_t djoy_sample(FAR const struct
djoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
- djoy_interrupt_t handler, FAR void *arg)
+ djoy_interrupt_t handler, void *arg)
Review Comment:
```suggestion
djoy_interrupt_t handler, void *arg)
```
##########
boards/arm/stm32/olimex-stm32-p407/src/stm32_djoystick.c:
##########
@@ -152,9 +152,9 @@ static djoy_buttonset_t djoy_sample(FAR const struct
djoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
Review Comment:
```suggestion
djoy_buttonset_t press, djoy_buttonset_t release,
```
##########
boards/arm/stm32/stm3210e-eval/src/stm32_djoystick.c:
##########
@@ -152,9 +152,9 @@ static djoy_buttonset_t djoy_sample(FAR const struct
djoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
Review Comment:
```suggestion
djoy_buttonset_t press, djoy_buttonset_t release,
```
##########
boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c:
##########
@@ -154,21 +154,21 @@ static const uint32_t g_lcdpin[] =
/* Command and data transmission control */
-static int stm32_ili93418b_recvblock(FAR struct ili9341_lcd_s *lcd,
+static int stm32_ili93418b_recvblock(struct ili9341_lcd_s *lcd,
uint16_t *wd, uint16_t nwords);
-static void stm32_ili93418b_deselect(FAR struct ili9341_lcd_s *lcd);
-static void stm32_ili93418b_select(FAR struct ili9341_lcd_s *lcd);
-static int stm32_ili93418b_sendcmd(FAR struct ili9341_lcd_s *lcd,
+static void stm32_ili93418b_deselect(struct ili9341_lcd_s *lcd);
+static void stm32_ili93418b_select(struct ili9341_lcd_s *lcd);
+static int stm32_ili93418b_sendcmd(struct ili9341_lcd_s *lcd,
const uint8_t cmd);
Review Comment:
```suggestion
static int stm32_ili93418b_sendcmd(struct ili9341_lcd_s *lcd,
const uint8_t cmd);
```
##########
boards/arm/stm32/nucleo-g431rb/src/stm32_cordic.c:
##########
@@ -48,7 +48,7 @@
int stm32_cordic_setup(void)
{
- FAR struct cordic_lowerhalf_s *cordic = NULL;
+ struct cordic_lowerhalf_s *cordic = NULL;
static bool initialized = false;
int ret = OK;
Review Comment:
```suggestion
static bool initialized = false;
int ret = OK;
```
##########
boards/arm/stm32/olimex-stm32-p407/src/stm32_djoystick.c:
##########
@@ -152,9 +152,9 @@ static djoy_buttonset_t djoy_sample(FAR const struct
djoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void djoy_enable(FAR const struct djoy_lowerhalf_s *lower,
+static void djoy_enable(const struct djoy_lowerhalf_s *lower,
djoy_buttonset_t press, djoy_buttonset_t release,
- djoy_interrupt_t handler, FAR void *arg)
+ djoy_interrupt_t handler, void *arg)
Review Comment:
```suggestion
djoy_interrupt_t handler, void *arg)
```
##########
boards/arm/stm32/nucleo-f4x1re/src/stm32_ajoystick.c:
##########
@@ -316,9 +316,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
- ajoy_handler_t handler, FAR void *arg)
+ ajoy_handler_t handler, void *arg)
Review Comment:
```suggestion
ajoy_handler_t handler, void *arg)
```
##########
boards/arm/stm32/nucleo-f4x1re/src/stm32_ajoystick.c:
##########
@@ -316,9 +316,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
Review Comment:
```suggestion
ajoy_buttonset_t press, ajoy_buttonset_t release,
```
##########
boards/arm/stm32/nucleo-f4x1re/src/stm32_ajoystick.c:
##########
@@ -101,17 +101,17 @@
****************************************************************************/
static ajoy_buttonset_t
-ajoy_supported(FAR const struct ajoy_lowerhalf_s *lower);
-static int ajoy_sample(FAR const struct ajoy_lowerhalf_s *lower,
- FAR struct ajoy_sample_s *sample);
+ajoy_supported(const struct ajoy_lowerhalf_s *lower);
+static int ajoy_sample(const struct ajoy_lowerhalf_s *lower,
+ struct ajoy_sample_s *sample);
static ajoy_buttonset_t
-ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower);
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+ajoy_buttons(const struct ajoy_lowerhalf_s *lower);
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
Review Comment:
```suggestion
ajoy_buttonset_t press, ajoy_buttonset_t release,
```
##########
boards/arm/stm32/nucleo-f4x1re/src/stm32_ajoystick.c:
##########
@@ -101,17 +101,17 @@
****************************************************************************/
static ajoy_buttonset_t
-ajoy_supported(FAR const struct ajoy_lowerhalf_s *lower);
-static int ajoy_sample(FAR const struct ajoy_lowerhalf_s *lower,
- FAR struct ajoy_sample_s *sample);
+ajoy_supported(const struct ajoy_lowerhalf_s *lower);
+static int ajoy_sample(const struct ajoy_lowerhalf_s *lower,
+ struct ajoy_sample_s *sample);
static ajoy_buttonset_t
-ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower);
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+ajoy_buttons(const struct ajoy_lowerhalf_s *lower);
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
- ajoy_handler_t handler, FAR void *arg);
+ ajoy_handler_t handler, void *arg);
Review Comment:
```suggestion
ajoy_handler_t handler, void *arg);
```
##########
boards/arm/stm32/nucleo-f446re/src/stm32_ajoystick.c:
##########
@@ -317,9 +317,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
Review Comment:
```suggestion
ajoy_buttonset_t press, ajoy_buttonset_t release,
```
##########
boards/arm/stm32/nucleo-f446re/src/stm32_spi.c:
##########
@@ -209,21 +209,21 @@ uint8_t stm32_spi3status(FAR struct spi_dev_s *dev,
uint32_t devid)
#ifdef CONFIG_SPI_CMDDATA
#ifdef CONFIG_STM32_SPI1
-int stm32_spi1cmddata(FAR struct spi_dev_s *dev, uint32_t devid, bool cmd)
+int stm32_spi1cmddata(struct spi_dev_s *dev, uint32_t devid, bool cmd)
{
return OK;
}
#endif
#ifdef CONFIG_STM32_SPI2
-int stm32_spi2cmddata(FAR struct spi_dev_s *dev, uint32_t devid, bool cmd)
+int stm32_spi2cmddata(struct spi_dev_s *dev, uint32_t devid, bool cmd)
{
return OK;
}
#endif
#ifdef CONFIG_STM32_SPI3
-int stm32_spi3cmddata(FAR struct spi_dev_s *dev, uint32_t devid, bool cmd)
+int stm32_spi3cmddata(struct spi_dev_s *dev, uint32_t devid, bool cmd)
{
stm32_gpiowrite(GPIO_LCD_RS, !cmd);
return OK;
Review Comment:
```suggestion
stm32_gpiowrite(GPIO_LCD_RS, !cmd);
return OK;
```
##########
boards/arm/stm32/nucleo-f446re/src/stm32_ajoystick.c:
##########
@@ -317,9 +317,9 @@ ajoy_buttons(FAR const struct ajoy_lowerhalf_s *lower)
*
****************************************************************************/
-static void ajoy_enable(FAR const struct ajoy_lowerhalf_s *lower,
+static void ajoy_enable(const struct ajoy_lowerhalf_s *lower,
ajoy_buttonset_t press, ajoy_buttonset_t release,
- ajoy_handler_t handler, FAR void *arg)
+ ajoy_handler_t handler, void *arg)
Review Comment:
```suggestion
ajoy_handler_t handler, void *arg)
```
##########
boards/arm/stm32/nucleo-f334r8/src/stm32_highpri.c:
##########
@@ -132,9 +132,9 @@
struct highpri_s
{
- FAR struct stm32_adc_dev_s *adc1;
+ struct stm32_adc_dev_s *adc1;
#ifdef HIGHPRI_HAVE_HRTIM
- FAR struct hrtim_dev_s *hrtim;
+ struct hrtim_dev_s *hrtim;
#endif
#ifdef HIGHPRI_HAVE_TIM1
struct stm32_pwm_dev_s *pwm;
Review Comment:
```suggestion
struct stm32_pwm_dev_s *pwm;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
