pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r862365468
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2354,7 +2354,7 @@ static void sam_blocksetup(FAR struct sdio_dev_s *dev,
****************************************************************************/
#ifndef CONFIG_SAMA5_SDMMC_DMA
-static int sam_recvsetup(FAR struct sdio_dev_s *dev, FAR uint8_t *buffer,
+static int sam_recvsetup(struct sdio_dev_s *dev, uint8_t *buffer,
size_t nbytes)
Review Comment:
```suggestion
static int sam_recvsetup(struct sdio_dev_s *dev, uint8_t *buffer,
size_t nbytes)
```
##########
arch/arm/src/sam34/sam_rtt.c:
##########
@@ -596,10 +596,10 @@ static void sam34_setcallback(FAR struct
timer_lowerhalf_s *lower,
*
****************************************************************************/
-static int sam34_ioctl(FAR struct timer_lowerhalf_s *lower, int cmd,
+static int sam34_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam34_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/sam34/sam_tc.c:
##########
@@ -544,10 +544,10 @@ static void sam34_setcallback(FAR struct
timer_lowerhalf_s *lower,
*
****************************************************************************/
-static int sam34_ioctl(FAR struct timer_lowerhalf_s *lower, int cmd,
+static int sam34_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam34_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -3056,8 +3056,8 @@ static int sam_registercallback(FAR struct sdio_dev_s
*dev,
****************************************************************************/
#ifdef CONFIG_SAMA5_SDMMC_DMA
-static int sam_dmarecvsetup(FAR struct sdio_dev_s *dev,
- FAR uint8_t *buffer, size_t buflen)
+static int sam_dmarecvsetup(struct sdio_dev_s *dev,
+ uint8_t *buffer, size_t buflen)
Review Comment:
```suggestion
static int sam_dmarecvsetup(struct sdio_dev_s *dev,
uint8_t *buffer, size_t buflen)
```
##########
arch/arm/src/sama5/sam_wdt.c:
##########
@@ -617,7 +617,7 @@ static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_ioctl(FAR struct watchdog_lowerhalf_s *lower, int cmd,
+static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/samd5e5/sam_usb.c:
##########
@@ -7284,17 +7284,17 @@ static int sam_free(FAR struct usbhost_driver_s *drvr,
FAR uint8_t *buffer)
*
****************************************************************************/
-static int sam_ioalloc(FAR struct usbhost_driver_s *drvr,
- FAR uint8_t **buffer, size_t buflen)
+static int sam_ioalloc(struct usbhost_driver_s *drvr,
+ uint8_t **buffer, size_t buflen)
Review Comment:
```suggestion
static int sam_ioalloc(struct usbhost_driver_s *drvr,
uint8_t **buffer, size_t buflen)
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -672,10 +672,10 @@ static int sam_afec_trigger(struct samv7_dev_s *priv)
*
****************************************************************************/
-static int afec_bind(FAR struct adc_dev_s *dev,
- FAR const struct adc_callback_s *callback)
+static int afec_bind(struct adc_dev_s *dev,
+ const struct adc_callback_s *callback)
Review Comment:
```suggestion
static int afec_bind(struct adc_dev_s *dev,
const struct adc_callback_s *callback)
```
##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -202,28 +202,28 @@ static struct sam_pwm_s g_pwm1 =
* Private Function Prototypes
****************************************************************************/
-static void pwm_putreg(FAR struct sam_pwm_s *priv, uint32_t offset,
+static void pwm_putreg(struct sam_pwm_s *priv, uint32_t offset,
uint32_t value);
-static uint32_t pwm_getreg(FAR struct sam_pwm_s *priv, uint32_t offset);
+static uint32_t pwm_getreg(struct sam_pwm_s *priv, uint32_t offset);
/* Helper functions */
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
Review Comment:
```suggestion
static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
```
##########
arch/arm/src/samv7/sam_wdt.c:
##########
@@ -628,7 +628,7 @@ static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_ioctl(FAR struct watchdog_lowerhalf_s *lower, int cmd,
+static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/stm32/stm32_fdcan.c:
##########
@@ -2539,9 +2539,9 @@ static bool fdcan_txempty(FAR struct can_dev_s *dev)
****************************************************************************/
#ifdef CONFIG_CAN_ERRORS
-static void fdcan_error(FAR struct can_dev_s *dev, uint32_t status)
+static void fdcan_error(struct can_dev_s *dev, uint32_t status)
{
- FAR struct stm32_fdcan_s *priv = dev->cd_priv;
+ struct stm32_fdcan_s *priv = dev->cd_priv;
struct can_hdr_s hdr;
uint32_t psr = 0;
uint16_t errbits = 0;
Review Comment:
```suggestion
struct can_hdr_s hdr;
uint32_t psr = 0;
uint16_t errbits = 0;
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2617,10 +2617,10 @@ static int sam_waitresponse(FAR struct sdio_dev_s *dev,
uint32_t cmd)
*
****************************************************************************/
-static int sam_recvshortcrc(FAR struct sdio_dev_s *dev, uint32_t cmd,
+static int sam_recvshortcrc(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t *rshort)
Review Comment:
```suggestion
static int sam_recvshortcrc(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t *rshort)
```
##########
arch/arm/src/stm32/stm32_dma_v2.c:
##########
@@ -254,7 +254,7 @@ static inline void stm32_dmagive(FAR struct stm32_dma_s
*dmast)
*
****************************************************************************/
-static inline FAR struct stm32_dma_s *stm32_dmastream(unsigned int stream,
+static inline struct stm32_dma_s *stm32_dmastream(unsigned int stream,
unsigned int controller)
Review Comment:
```suggestion
static inline struct stm32_dma_s *stm32_dmastream(unsigned int stream,
unsigned int controller)
```
##########
arch/arm/src/sam34/sam_wdt.c:
##########
@@ -588,10 +588,10 @@ static xcpt_t sam34_capture(FAR struct
watchdog_lowerhalf_s *lower,
*
****************************************************************************/
-static int sam34_ioctl(FAR struct watchdog_lowerhalf_s *lower, int cmd,
+static int sam34_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam34_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2063,10 +2063,10 @@ static int sam_attach(FAR struct sdio_dev_s *dev)
*
****************************************************************************/
-static int sam_sendcmd(FAR struct sdio_dev_s *dev, uint32_t cmd,
+static int sam_sendcmd(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t arg)
Review Comment:
```suggestion
static int sam_sendcmd(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t arg)
```
##########
arch/arm/src/sama5/sam_wdt.c:
##########
@@ -554,14 +554,14 @@ static int sam_settimeout(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s *lower,
+static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
Review Comment:
```suggestion
static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2315,11 +2315,11 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
uint32_t cmd,
****************************************************************************/
#ifdef CONFIG_SDIO_BLOCKSETUP
-static void sam_blocksetup(FAR struct sdio_dev_s *dev,
+static void sam_blocksetup(struct sdio_dev_s *dev,
unsigned int blocklen,
unsigned int nblocks)
Review Comment:
```suggestion
static void sam_blocksetup(struct sdio_dev_s *dev,
unsigned int blocklen,
unsigned int nblocks)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2752,10 +2752,10 @@ static int sam_recvlong(FAR struct sdio_dev_s *dev,
uint32_t cmd,
return ret;
}
-static int sam_recvshort(FAR struct sdio_dev_s *dev, uint32_t cmd,
+static int sam_recvshort(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t *rshort)
Review Comment:
```suggestion
static int sam_recvshort(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t *rshort)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2986,7 +2986,7 @@ static sdio_eventset_t sam_eventwait(FAR struct
sdio_dev_s *dev)
*
****************************************************************************/
-static void sam_callbackenable(FAR struct sdio_dev_s *dev,
+static void sam_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
Review Comment:
```suggestion
static void sam_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2413,8 +2413,8 @@ static int sam_recvsetup(FAR struct sdio_dev_s *dev, FAR
uint8_t *buffer,
****************************************************************************/
#ifndef CONFIG_SAMA5_SDMMC_DMA
-static int sam_sendsetup(FAR struct sdio_dev_s *dev,
- FAR const uint8_t *buffer,
+static int sam_sendsetup(struct sdio_dev_s *dev,
+ const uint8_t *buffer,
size_t nbytes)
Review Comment:
```suggestion
static int sam_sendsetup(struct sdio_dev_s *dev,
const uint8_t *buffer,
size_t nbytes)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2694,10 +2694,10 @@ static int sam_recvshortcrc(FAR struct sdio_dev_s *dev,
uint32_t cmd,
return ret;
}
-static int sam_recvlong(FAR struct sdio_dev_s *dev, uint32_t cmd,
+static int sam_recvlong(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t rlong[4])
Review Comment:
```suggestion
static int sam_recvlong(struct sdio_dev_s *dev, uint32_t cmd,
uint32_t rlong[4])
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -2827,7 +2827,7 @@ static int sam_recvshort(FAR struct sdio_dev_s *dev,
uint32_t cmd,
*
****************************************************************************/
-static void sam_waitenable(FAR struct sdio_dev_s *dev,
+static void sam_waitenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset, uint32_t timeout)
Review Comment:
```suggestion
static void sam_waitenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset, uint32_t timeout)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -3020,7 +3020,7 @@ static void sam_callbackenable(FAR struct sdio_dev_s *dev,
*
****************************************************************************/
-static int sam_registercallback(FAR struct sdio_dev_s *dev,
+static int sam_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
Review Comment:
```suggestion
static int sam_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
```
##########
arch/arm/src/sama5/sam_wdt.c:
##########
@@ -432,10 +432,10 @@ static int sam_getstatus(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -145,15 +145,15 @@ static int sam_afec_trigger(struct samv7_dev_s *priv);
/* ADC methods */
-static int afec_bind(FAR struct adc_dev_s *dev,
- FAR const struct adc_callback_s *callback);
-static void afec_reset(FAR struct adc_dev_s *dev);
-static int afec_setup(FAR struct adc_dev_s *dev);
-static void afec_shutdown(FAR struct adc_dev_s *dev);
-static void afec_rxint(FAR struct adc_dev_s *dev, bool enable);
-static int afec_ioctl(FAR struct adc_dev_s *dev,
+static int afec_bind(struct adc_dev_s *dev,
+ const struct adc_callback_s *callback);
Review Comment:
```suggestion
static int afec_bind(struct adc_dev_s *dev,
const struct adc_callback_s *callback);
```
##########
arch/arm/src/sama5/sam_sdmmc.h:
##########
@@ -79,7 +79,7 @@ extern "C"
*
****************************************************************************/
-void sam_sdmmc_set_sdio_card_isr(FAR struct sdio_dev_s *dev,
+void sam_sdmmc_set_sdio_card_isr(struct sdio_dev_s *dev,
int (*func)(void *), void *arg);
Review Comment:
```suggestion
void sam_sdmmc_set_sdio_card_isr(struct sdio_dev_s *dev,
int (*func)(void *), void *arg);
```
##########
arch/arm/src/samd5e5/sam_wdt.c:
##########
@@ -340,10 +340,10 @@ static int sam_getstatus(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/sama5/sam_sdmmc.c:
##########
@@ -3128,8 +3128,8 @@ static int sam_dmarecvsetup(FAR struct sdio_dev_s *dev,
****************************************************************************/
#ifdef CONFIG_SAMA5_SDMMC_DMA
-static int sam_dmasendsetup(FAR struct sdio_dev_s *dev,
- FAR const uint8_t *buffer, size_t buflen)
+static int sam_dmasendsetup(struct sdio_dev_s *dev,
+ const uint8_t *buffer, size_t buflen)
Review Comment:
```suggestion
static int sam_dmasendsetup(struct sdio_dev_s *dev,
const uint8_t *buffer, size_t buflen)
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -442,10 +442,10 @@ static void sam_afec_dmacallback(DMA_HANDLE handle, void
*arg, int result)
*
****************************************************************************/
-static int sam_afec_dmasetup(FAR struct adc_dev_s *dev, FAR uint8_t *buffer,
+static int sam_afec_dmasetup(struct adc_dev_s *dev, uint8_t *buffer,
size_t buflen)
Review Comment:
```suggestion
static int sam_afec_dmasetup(struct adc_dev_s *dev, uint8_t *buffer,
size_t buflen)
```
##########
arch/arm/src/samd5e5/sam_wdt.c:
##########
@@ -281,10 +281,10 @@ static int sam_keepalive(FAR struct watchdog_lowerhalf_s
*lower)
*
****************************************************************************/
-static int sam_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status)
+static int sam_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status)
Review Comment:
```suggestion
static int sam_getstatus(struct watchdog_lowerhalf_s *lower,
struct watchdog_status_s *status)
```
##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -202,28 +202,28 @@ static struct sam_pwm_s g_pwm1 =
* Private Function Prototypes
****************************************************************************/
-static void pwm_putreg(FAR struct sam_pwm_s *priv, uint32_t offset,
+static void pwm_putreg(struct sam_pwm_s *priv, uint32_t offset,
uint32_t value);
-static uint32_t pwm_getreg(FAR struct sam_pwm_s *priv, uint32_t offset);
+static uint32_t pwm_getreg(struct sam_pwm_s *priv, uint32_t offset);
/* Helper functions */
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
-static int pwm_change_freq(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info, uint8_t channel);
+static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info, uint8_t channel);
Review Comment:
```suggestion
static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
uint8_t channel);
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -253,13 +253,13 @@ gpio_pinset_t g_adcpinlist1[ADC_MAX_CHANNELS] =
* Private Functions
****************************************************************************/
-static void afec_putreg(FAR struct samv7_dev_s *priv, uint32_t offset,
+static void afec_putreg(struct samv7_dev_s *priv, uint32_t offset,
uint32_t value)
Review Comment:
```suggestion
static void afec_putreg(struct samv7_dev_s *priv, uint32_t offset,
uint32_t value)
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -480,14 +480,14 @@ static int sam_afec_dmasetup(FAR struct adc_dev_s *dev,
FAR uint8_t *buffer,
static void sam_afec_dmastart(struct adc_dev_s *dev)
{
- FAR struct samv7_dev_s *priv = (FAR struct samv7_dev_s *)dev->ad_priv;
+ struct samv7_dev_s *priv = (struct samv7_dev_s *)dev->ad_priv;
/* Make sure that the worker is available and that DMA is not disabled */
if (priv->ready && priv->enabled)
{
priv->odd = false; /* Start with the even buffer */
- sam_afec_dmasetup(dev, (FAR uint8_t *)priv->evenbuf,
+ sam_afec_dmasetup(dev, (uint8_t *)priv->evenbuf,
priv->nsamples * sizeof(uint32_t));
Review Comment:
```suggestion
sam_afec_dmasetup(dev, (uint8_t *)priv->evenbuf,
priv->nsamples * sizeof(uint32_t));
```
##########
arch/arm/src/samd5e5/sam_usb.c:
##########
@@ -7821,11 +7821,11 @@ static int sam_cancel(FAR struct usbhost_driver_s
*drvr, usbhost_ep_t ep)
****************************************************************************/
#ifdef CONFIG_USBHOST_HUB
-static int sam_connect(FAR struct usbhost_driver_s *drvr,
- FAR struct usbhost_hubport_s *hport,
+static int sam_connect(struct usbhost_driver_s *drvr,
+ struct usbhost_hubport_s *hport,
bool connected)
Review Comment:
```suggestion
static int sam_connect(struct usbhost_driver_s *drvr,
struct usbhost_hubport_s *hport,
bool connected)
```
##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -244,10 +244,10 @@ static uint32_t pwm_getreg(FAR struct sam_pwm_s *priv,
uint32_t offset)
*
****************************************************************************/
-static int pwm_change_freq(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info, uint8_t channel)
+static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info, uint8_t channel)
Review Comment:
```suggestion
static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
uint8_t channel)
```
##########
arch/arm/src/samv7/sam_afec.c:
##########
@@ -1079,12 +1079,12 @@ static int afec_interrupt(int irq, void *context, FAR
void *arg)
*
****************************************************************************/
-FAR struct adc_dev_s *sam_afec_initialize(int intf,
- FAR const uint8_t *chanlist,
+struct adc_dev_s *sam_afec_initialize(int intf,
+ const uint8_t *chanlist,
int nchannels)
Review Comment:
```suggestion
struct adc_dev_s *sam_afec_initialize(int intf,
const uint8_t *chanlist,
int nchannels)
```
##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -305,10 +305,10 @@ static int pwm_change_freq(FAR struct pwm_lowerhalf_s
*dev,
*
****************************************************************************/
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty)
Review Comment:
```suggestion
static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty)
```
##########
arch/arm/src/samv7/sam_afec.h:
##########
@@ -77,8 +77,8 @@ extern "C"
*
****************************************************************************/
-FAR struct adc_dev_s *sam_afec_initialize(int intf,
- FAR const uint8_t *chanlist,
+struct adc_dev_s *sam_afec_initialize(int intf,
+ const uint8_t *chanlist,
int nchannels);
Review Comment:
```suggestion
struct adc_dev_s *sam_afec_initialize(int intf,
const uint8_t *chanlist,
int nchannels);
```
##########
arch/arm/src/samv7/sam_rswdt.c:
##########
@@ -554,14 +554,14 @@ static int sam_settimeout(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s *lower,
+static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
Review Comment:
```suggestion
static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
```
##########
arch/arm/src/samv7/sam_rswdt.c:
##########
@@ -433,10 +433,10 @@ static int sam_getstatus(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/samv7/sam_wdt.c:
##########
@@ -431,10 +431,10 @@ static int sam_getstatus(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int sam_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/stm32/stm32_comp_v2.c:
##########
@@ -80,31 +80,31 @@ struct stm32_comp_s
/* COMP Register access */
-static inline void comp_modify_csr(FAR struct stm32_comp_s *priv,
+static inline void comp_modify_csr(struct stm32_comp_s *priv,
uint32_t clearbits, uint32_t setbits);
-static inline uint32_t comp_getreg_csr(FAR struct stm32_comp_s *priv);
-static inline void comp_putreg_csr(FAR struct stm32_comp_s *priv,
+static inline uint32_t comp_getreg_csr(struct stm32_comp_s *priv);
+static inline void comp_putreg_csr(struct stm32_comp_s *priv,
uint32_t value);
/* COMP Driver Methods */
#if defined (CONFIG_COMP)
-static void comp_shutdown(FAR struct comp_dev_s *dev);
-static int comp_setup(FAR struct comp_dev_s *dev);
-static int comp_read(FAR struct comp_dev_s *dev);
-static int comp_ioctl(FAR struct comp_dev_s *dev, int cmd,
+static void comp_shutdown(struct comp_dev_s *dev);
+static int comp_setup(struct comp_dev_s *dev);
+static int comp_read(struct comp_dev_s *dev);
+static int comp_ioctl(struct comp_dev_s *dev, int cmd,
unsigned long arg);
Review Comment:
```suggestion
static int comp_ioctl(struct comp_dev_s *dev, int cmd,
unsigned long arg);
```
##########
arch/arm/src/stm32/stm32_1wire.c:
##########
@@ -1109,7 +1109,7 @@ static int stm32_1wire_read(FAR struct onewire_dev_s
*dev, uint8_t *buffer,
*
****************************************************************************/
-static int stm32_1wire_exchange(FAR struct onewire_dev_s *dev, bool reset,
+static int stm32_1wire_exchange(struct onewire_dev_s *dev, bool reset,
const uint8_t *txbuffer, int txbuflen,
uint8_t *rxbuffer, int rxbuflen)
Review Comment:
```suggestion
static int stm32_1wire_exchange(struct onewire_dev_s *dev, bool reset,
const uint8_t *txbuffer, int txbuflen,
uint8_t *rxbuffer, int rxbuflen)
```
##########
arch/arm/src/samv7/sam_rswdt.c:
##########
@@ -617,7 +617,7 @@ static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_ioctl(FAR struct watchdog_lowerhalf_s *lower, int cmd,
+static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int sam_ioctl(struct watchdog_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/samv7/sam_wdt.c:
##########
@@ -565,14 +565,14 @@ static int sam_settimeout(FAR struct watchdog_lowerhalf_s
*lower,
*
****************************************************************************/
-static xcpt_t sam_capture(FAR struct watchdog_lowerhalf_s *lower,
+static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
Review Comment:
```suggestion
static xcpt_t sam_capture(struct watchdog_lowerhalf_s *lower,
xcpt_t handler)
```
##########
arch/arm/src/stm32/stm32_comp_v2.c:
##########
@@ -80,31 +80,31 @@ struct stm32_comp_s
/* COMP Register access */
-static inline void comp_modify_csr(FAR struct stm32_comp_s *priv,
+static inline void comp_modify_csr(struct stm32_comp_s *priv,
uint32_t clearbits, uint32_t setbits);
Review Comment:
```suggestion
static inline void comp_modify_csr(struct stm32_comp_s *priv,
uint32_t clearbits,
uint32_t setbits);
```
##########
arch/arm/src/stm32/stm32_comp_v2.c:
##########
@@ -80,31 +80,31 @@ struct stm32_comp_s
/* COMP Register access */
-static inline void comp_modify_csr(FAR struct stm32_comp_s *priv,
+static inline void comp_modify_csr(struct stm32_comp_s *priv,
uint32_t clearbits, uint32_t setbits);
-static inline uint32_t comp_getreg_csr(FAR struct stm32_comp_s *priv);
-static inline void comp_putreg_csr(FAR struct stm32_comp_s *priv,
+static inline uint32_t comp_getreg_csr(struct stm32_comp_s *priv);
+static inline void comp_putreg_csr(struct stm32_comp_s *priv,
uint32_t value);
Review Comment:
```suggestion
static inline void comp_putreg_csr(struct stm32_comp_s *priv,
uint32_t value);
```
##########
arch/arm/src/stm32/stm32_fdcan_sock.c:
##########
@@ -2036,9 +2036,9 @@ static void fdcan_txdone(FAR struct stm32_fdcan_s *priv)
* Name: fdcan_error_work
****************************************************************************/
-static void fdcan_error_work(FAR void *arg)
+static void fdcan_error_work(void *arg)
{
- FAR struct stm32_fdcan_s *priv = (FAR struct stm32_fdcan_s *)arg;
+ struct stm32_fdcan_s *priv = (struct stm32_fdcan_s *)arg;
uint32_t pending = 0;
uint32_t ir = 0;
uint32_t ie = 0;
Review Comment:
```suggestion
uint32_t pending = 0;
uint32_t ir = 0;
uint32_t ie = 0;
```
##########
arch/arm/src/samv7/sam_tc_lowerhalf.c:
##########
@@ -658,8 +658,8 @@ int sam_timer_initialize(FAR const char *devpath, int chan)
* REVISIT: The returned handle is discard here.
*/
- FAR void *drvr = timer_register(devpath,
- (FAR struct timer_lowerhalf_s *)lower);
+ void *drvr = timer_register(devpath,
+ (struct timer_lowerhalf_s *)lower);
Review Comment:
```suggestion
void *drvr = timer_register(devpath,
(struct timer_lowerhalf_s *)lower);
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -2146,7 +2146,7 @@ stm32_foc_initialize(int inst, FAR struct
stm32_foc_board_s *board)
uint32_t pwmfzbit = 0;
int i = 0;
#ifdef CONFIG_STM32_FOC_G4_ADCCHAN0_WORKAROUND
- FAR uint8_t *adc_chan = NULL;
+ uint8_t *adc_chan = NULL;
uint8_t adc_nchan = 0;
Review Comment:
```suggestion
uint8_t adc_nchan = 0;
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -2127,16 +2127,16 @@ void stm32_foc_trace(FAR struct foc_dev_s *dev, int
type, bool state)
*
****************************************************************************/
-FAR struct foc_dev_s *
-stm32_foc_initialize(int inst, FAR struct stm32_foc_board_s *board)
+struct foc_dev_s *
+stm32_foc_initialize(int inst, struct stm32_foc_board_s *board)
{
- FAR struct foc_dev_s *dev = NULL;
- FAR struct stm32_foc_adc_s *adc_cfg = NULL;
- FAR struct foc_lower_s *foc_lower = NULL;
- FAR struct stm32_foc_dev_s *foc_dev = NULL;
- FAR struct stm32_foc_priv_s *foc_priv = NULL;
+ struct foc_dev_s *dev = NULL;
+ struct stm32_foc_adc_s *adc_cfg = NULL;
+ struct foc_lower_s *foc_lower = NULL;
+ struct stm32_foc_dev_s *foc_dev = NULL;
+ struct stm32_foc_priv_s *foc_priv = NULL;
#ifdef FOC_ADC_HAVE_CMN
- FAR struct stm32_foc_adccmn_s *adc_cmn = NULL;
+ struct stm32_foc_adccmn_s *adc_cmn = NULL;
#endif
uint32_t adc_irq = 0;
uint32_t pwm_base = 0;
Review Comment:
```suggestion
uint32_t adc_irq = 0;
uint32_t pwm_base = 0;
```
##########
arch/arm/src/stm32/stm32_ltdc.c:
##########
@@ -2091,11 +2091,11 @@ static void stm32_ltdc_lputclut(FAR struct stm32_ltdc_s
*layer,
*
****************************************************************************/
-static void stm32_ltdc_lgetclut(FAR struct stm32_ltdc_s * layer,
- FAR struct fb_cmap_s * cmap)
+static void stm32_ltdc_lgetclut(struct stm32_ltdc_s * layer,
+ struct fb_cmap_s * cmap)
Review Comment:
```suggestion
static void stm32_ltdc_lgetclut(struct stm32_ltdc_s * layer,
struct fb_cmap_s * cmap)
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -2146,7 +2146,7 @@ stm32_foc_initialize(int inst, FAR struct
stm32_foc_board_s *board)
uint32_t pwmfzbit = 0;
int i = 0;
Review Comment:
```suggestion
uint32_t pwmfzbit = 0;
int i = 0;
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -885,8 +885,8 @@ static struct foc_dev_s g_foc_dev[CONFIG_MOTOR_FOC_INST];
void stm32_foc_sync_all(void)
{
- FAR struct foc_dev_s *dev = NULL;
- FAR struct stm32_foc_dev_s *foc_dev = NULL;
+ struct foc_dev_s *dev = NULL;
+ struct stm32_foc_dev_s *foc_dev = NULL;
uint32_t egr_reg[CONFIG_MOTOR_FOC_INST];
int i = 0;
Review Comment:
```suggestion
uint32_t egr_reg[CONFIG_MOTOR_FOC_INST];
int i = 0;
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -1935,11 +1935,11 @@ static void stm32_foc_hw_config_get(FAR struct
foc_dev_s *dev)
*
****************************************************************************/
-static void stm32_foc_curr_get(FAR struct foc_dev_s *dev,
- FAR int16_t *curr, int shunts)
+static void stm32_foc_curr_get(struct foc_dev_s *dev,
+ int16_t *curr, int shunts)
{
- FAR struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
- FAR struct stm32_adc_dev_s *adc = ADC_FROM_FOC_DEV_GET(dev);
+ struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
+ struct stm32_adc_dev_s *adc = ADC_FROM_FOC_DEV_GET(dev);
int i = 0;
Review Comment:
```suggestion
int i = 0;
```
##########
arch/arm/src/stm32/stm32_hall3ph.c:
##########
@@ -129,10 +129,10 @@ int stm32_hall3ph_shutdown(FAR struct hall3_lowerhalf_s
*lower)
*
****************************************************************************/
-int stm32_hall3ph_position(FAR struct hall3_lowerhalf_s *lower,
- FAR uint8_t *pos)
+int stm32_hall3ph_position(struct hall3_lowerhalf_s *lower,
+ uint8_t *pos)
{
- FAR struct stm32_lowerhalf_s *priv = (FAR struct stm32_lowerhalf_s *)lower;
+ struct stm32_lowerhalf_s *priv = (struct stm32_lowerhalf_s *)lower;
uint8_t ha = 0;
uint8_t hb = 0;
uint8_t hc = 0;
Review Comment:
```suggestion
uint8_t ha = 0;
uint8_t hb = 0;
uint8_t hc = 0;
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -1857,11 +1857,11 @@ static int stm32_foc_calibration_start(FAR struct
foc_dev_s *dev)
*
****************************************************************************/
-static int stm32_foc_pwm_duty_set(FAR struct foc_dev_s *dev,
- FAR foc_duty_t *duty)
+static int stm32_foc_pwm_duty_set(struct foc_dev_s *dev,
+ foc_duty_t *duty)
{
- FAR struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
- FAR struct stm32_foc_dev_s *foc_dev = STM32_FOC_DEV_FROM_DEV_GET(dev);
+ struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
+ struct stm32_foc_dev_s *foc_dev = STM32_FOC_DEV_FROM_DEV_GET(dev);
uint16_t ccr[CONFIG_MOTOR_FOC_PHASES];
Review Comment:
```suggestion
uint16_t ccr[CONFIG_MOTOR_FOC_PHASES];
```
##########
arch/arm/src/stm32/stm32_foc.c:
##########
@@ -1446,11 +1446,11 @@ static int stm32_foc_setup(FAR struct foc_dev_s *dev)
*
****************************************************************************/
-static int stm32_foc_shutdown(FAR struct foc_dev_s *dev)
+static int stm32_foc_shutdown(struct foc_dev_s *dev)
{
- FAR struct stm32_foc_dev_s *foc_dev = STM32_FOC_DEV_FROM_DEV_GET(dev);
- FAR struct stm32_foc_board_s *board = STM32_FOC_BOARD_FROM_DEV_GET(dev);
- FAR struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
+ struct stm32_foc_dev_s *foc_dev = STM32_FOC_DEV_FROM_DEV_GET(dev);
+ struct stm32_foc_board_s *board = STM32_FOC_BOARD_FROM_DEV_GET(dev);
+ struct stm32_foc_priv_s *priv = STM32_FOC_PRIV_FROM_DEV_GET(dev);
int ret = OK;
Review Comment:
```suggestion
int ret = OK;
```
##########
arch/arm/src/stm32/stm32_oneshot_lowerhalf.c:
##########
@@ -296,15 +296,15 @@ static int stm32_cancel(FAR struct oneshot_lowerhalf_s
*lower,
*
****************************************************************************/
-FAR struct oneshot_lowerhalf_s *oneshot_initialize(int chan,
+struct oneshot_lowerhalf_s *oneshot_initialize(int chan,
uint16_t resolution)
Review Comment:
```suggestion
struct oneshot_lowerhalf_s *oneshot_initialize(int chan,
uint16_t resolution)
```
##########
arch/arm/src/stm32/stm32_rtc_lowerhalf.c:
##########
@@ -101,27 +101,27 @@ struct stm32_lowerhalf_s
/* Prototypes for static methods in struct rtc_ops_s */
-static int stm32_rdtime(FAR struct rtc_lowerhalf_s *lower,
- FAR struct rtc_time *rtctime);
-static int stm32_settime(FAR struct rtc_lowerhalf_s *lower,
- FAR const struct rtc_time *rtctime);
-static bool stm32_havesettime(FAR struct rtc_lowerhalf_s *lower);
+static int stm32_rdtime(struct rtc_lowerhalf_s *lower,
+ struct rtc_time *rtctime);
+static int stm32_settime(struct rtc_lowerhalf_s *lower,
+ const struct rtc_time *rtctime);
+static bool stm32_havesettime(struct rtc_lowerhalf_s *lower);
#ifdef CONFIG_RTC_ALARM
-static int stm32_setalarm(FAR struct rtc_lowerhalf_s *lower,
- FAR const struct lower_setalarm_s *alarminfo);
-static int stm32_setrelative(FAR struct rtc_lowerhalf_s *lower,
- FAR const struct lower_setrelative_s *alarminfo);
-static int stm32_cancelalarm(FAR struct rtc_lowerhalf_s *lower,
+static int stm32_setalarm(struct rtc_lowerhalf_s *lower,
+ const struct lower_setalarm_s *alarminfo);
+static int stm32_setrelative(struct rtc_lowerhalf_s *lower,
+ const struct lower_setrelative_s *alarminfo);
+static int stm32_cancelalarm(struct rtc_lowerhalf_s *lower,
int alarmid);
-static int stm32_rdalarm(FAR struct rtc_lowerhalf_s *lower,
- FAR struct lower_rdalarm_s *alarminfo);
+static int stm32_rdalarm(struct rtc_lowerhalf_s *lower,
+ struct lower_rdalarm_s *alarminfo);
#endif
#ifdef CONFIG_RTC_PERIODIC
-static int stm32_setperiodic(FAR struct rtc_lowerhalf_s *lower,
- FAR const struct lower_setperiodic_s *alarminfo);
-static int stm32_cancelperiodic(FAR struct rtc_lowerhalf_s *lower, int id);
+static int stm32_setperiodic(struct rtc_lowerhalf_s *lower,
+ const struct lower_setperiodic_s *alarminfo);
Review Comment:
```suggestion
static int stm32_setperiodic(struct rtc_lowerhalf_s *lower,
const struct lower_setperiodic_s *alarminfo);
```
##########
arch/arm/src/stm32/stm32_ltdc.c:
##########
@@ -2038,8 +2038,8 @@ static void stm32_ltdc_lclutenable(FAR struct
stm32_ltdc_s *layer,
*
****************************************************************************/
-static void stm32_ltdc_lputclut(FAR struct stm32_ltdc_s *layer,
- FAR const struct fb_cmap_s *cmap)
+static void stm32_ltdc_lputclut(struct stm32_ltdc_s *layer,
+ const struct fb_cmap_s *cmap)
Review Comment:
```suggestion
static void stm32_ltdc_lputclut(struct stm32_ltdc_s *layer,
const struct fb_cmap_s *cmap)
```
##########
arch/arm/src/stm32/stm32_opamp.c:
##########
@@ -468,7 +468,7 @@ static inline uint32_t opamp_getreg_csr(FAR struct
stm32_opamp_s *priv)
*
****************************************************************************/
-static inline void opamp_putreg_csr(FAR struct stm32_opamp_s *priv,
+static inline void opamp_putreg_csr(struct stm32_opamp_s *priv,
uint32_t value)
Review Comment:
```suggestion
static inline void opamp_putreg_csr(struct stm32_opamp_s *priv,
uint32_t value)
```
##########
arch/arm/src/stm32/stm32_tim_lowerhalf.c:
##########
@@ -568,8 +568,8 @@ int stm32_timer_initialize(FAR const char *devpath, int
timer)
* REVISIT: The returned handle is discard here.
*/
- FAR void *drvr = timer_register(devpath,
- (FAR struct timer_lowerhalf_s *)lower);
+ void *drvr = timer_register(devpath,
+ (struct timer_lowerhalf_s *)lower);
Review Comment:
```suggestion
void *drvr = timer_register(devpath,
(struct timer_lowerhalf_s *)lower);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
-static int stm32pwm_update_duty(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty);
Review Comment:
```suggestion
static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty);
```
##########
arch/arm/src/stm32/stm32_opamp.c:
##########
@@ -424,7 +424,7 @@ static struct opamp_dev_s g_opamp4dev =
*
****************************************************************************/
-static inline void opamp_modify_csr(FAR struct stm32_opamp_s *priv,
+static inline void opamp_modify_csr(struct stm32_opamp_s *priv,
uint32_t clearbits, uint32_t setbits)
Review Comment:
```suggestion
static inline void opamp_modify_csr(struct stm32_opamp_s *priv,
uint32_t clearbits, uint32_t setbits)
```
##########
arch/arm/src/stm32f0l0g0/stm32_adc.c:
##########
@@ -251,110 +251,110 @@ struct stm32_dev_s
static void stm32_modifyreg32(unsigned int addr, uint32_t clrbits,
uint32_t setbits);
-static uint32_t adc_getreg(FAR struct stm32_dev_s *priv, int offset);
-static void adc_putreg(FAR struct stm32_dev_s *priv, int offset,
+static uint32_t adc_getreg(struct stm32_dev_s *priv, int offset);
+static void adc_putreg(struct stm32_dev_s *priv, int offset,
uint32_t value);
-static void adc_modifyreg(FAR struct stm32_dev_s *priv, int offset,
+static void adc_modifyreg(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits);
#ifdef HAVE_ADC_CMN_REGS
-static uint32_t adccmn_base_get(FAR struct stm32_dev_s *priv);
-static void adccmn_modifyreg(FAR struct stm32_dev_s *priv, uint32_t offset,
+static uint32_t adccmn_base_get(struct stm32_dev_s *priv);
+static void adccmn_modifyreg(struct stm32_dev_s *priv, uint32_t offset,
uint32_t clrbits, uint32_t setbits);
-static uint32_t adccmn_getreg(FAR struct stm32_dev_s *priv, uint32_t offset);
+static uint32_t adccmn_getreg(struct stm32_dev_s *priv, uint32_t offset);
#endif
#ifdef ADC_HAVE_TIMER
-static uint16_t tim_getreg(FAR struct stm32_dev_s *priv, int offset);
-static void tim_putreg(FAR struct stm32_dev_s *priv, int offset,
+static uint16_t tim_getreg(struct stm32_dev_s *priv, int offset);
+static void tim_putreg(struct stm32_dev_s *priv, int offset,
uint16_t value);
-static void tim_modifyreg(FAR struct stm32_dev_s *priv, int offset,
+static void tim_modifyreg(struct stm32_dev_s *priv, int offset,
uint16_t clrbits, uint16_t setbits);
-static void tim_dumpregs(FAR struct stm32_dev_s *priv,
- FAR const char *msg);
+static void tim_dumpregs(struct stm32_dev_s *priv,
+ const char *msg);
Review Comment:
```suggestion
static void tim_dumpregs(struct stm32_dev_s *priv,
const char *msg);
```
##########
arch/arm/src/stm32/stm32_sdadc.c:
##########
@@ -769,10 +769,10 @@ static void sdadc_dmaconvcallback(DMA_HANDLE handle,
*
****************************************************************************/
-static int sdadc_bind(FAR struct adc_dev_s *dev,
- FAR const struct adc_callback_s *callback)
+static int sdadc_bind(struct adc_dev_s *dev,
+ const struct adc_callback_s *callback)
Review Comment:
```suggestion
static int sdadc_bind(struct adc_dev_s *dev,
const struct adc_callback_s *callback)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
const struct pwm_info_s *info);
```
##########
arch/arm/src/stm32f0l0g0/stm32_adc.c:
##########
@@ -251,110 +251,110 @@ struct stm32_dev_s
static void stm32_modifyreg32(unsigned int addr, uint32_t clrbits,
uint32_t setbits);
-static uint32_t adc_getreg(FAR struct stm32_dev_s *priv, int offset);
-static void adc_putreg(FAR struct stm32_dev_s *priv, int offset,
+static uint32_t adc_getreg(struct stm32_dev_s *priv, int offset);
+static void adc_putreg(struct stm32_dev_s *priv, int offset,
uint32_t value);
-static void adc_modifyreg(FAR struct stm32_dev_s *priv, int offset,
+static void adc_modifyreg(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits);
#ifdef HAVE_ADC_CMN_REGS
-static uint32_t adccmn_base_get(FAR struct stm32_dev_s *priv);
-static void adccmn_modifyreg(FAR struct stm32_dev_s *priv, uint32_t offset,
+static uint32_t adccmn_base_get(struct stm32_dev_s *priv);
+static void adccmn_modifyreg(struct stm32_dev_s *priv, uint32_t offset,
uint32_t clrbits, uint32_t setbits);
Review Comment:
```suggestion
static void adccmn_modifyreg(struct stm32_dev_s *priv, uint32_t offset,
uint32_t clrbits, uint32_t setbits);
```
##########
arch/arm/src/stm32f0l0g0/stm32_adc.c:
##########
@@ -553,7 +553,7 @@ static uint32_t adccmn_base_get(FAR struct stm32_dev_s
*priv)
* Name: adccmn_modifyreg
****************************************************************************/
-static void adccmn_modifyreg(FAR struct stm32_dev_s *priv, uint32_t offset,
+static void adccmn_modifyreg(struct stm32_dev_s *priv, uint32_t offset,
uint32_t clrbits, uint32_t setbits)
Review Comment:
```suggestion
static void adccmn_modifyreg(struct stm32_dev_s *priv, uint32_t offset,
uint32_t clrbits, uint32_t setbits)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
Review Comment:
```suggestion
static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
-static int stm32pwm_update_duty(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty);
-static void stm32pwm_setapbclock(FAR struct stm32_pwmtimer_s *priv, bool on);
+static void stm32pwm_setapbclock(struct stm32_pwmtimer_s *priv, bool on);
#if defined(CONFIG_PWM_PULSECOUNT) && \
(defined(CONFIG_STM32F0L0G0_TIM1_PWM) ||
defined(CONFIG_STM32F0L0G0_TIM8_PWM))
static int stm32pwm_interrupt(struct stm32_pwmtimer_s *priv);
# if defined(CONFIG_STM32F0L0G0_TIM1_PWM)
-static int stm32pwm_tim1interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim1interrupt(int irq, void *context, void *arg);
# endif
# if defined(CONFIG_STM32F0L0G0_TIM8_PWM)
-static int stm32pwm_tim8interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim8interrupt(int irq, void *context, void *arg);
# endif
static uint8_t stm32pwm_pulsecount(uint32_t count);
#endif /* CONFIG_PWM_PULSECOUNT && CONFIG_STM32F0L0G0_TIM{1,8}_PWM */
/* PWM driver methods */
-static int stm32pwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int stm32pwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int stm32pwm_setup(struct pwm_lowerhalf_s *dev);
+static int stm32pwm_shutdown(struct pwm_lowerhalf_s *dev);
#ifdef CONFIG_PWM_PULSECOUNT
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info,
- FAR void *handle);
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info,
+ void *handle);
Review Comment:
```suggestion
static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
void *handle);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -2147,11 +2147,11 @@ static int stm32pwm_stop(FAR struct pwm_lowerhalf_s
*dev)
*
****************************************************************************/
-static int stm32pwm_ioctl(FAR struct pwm_lowerhalf_s *dev, int cmd,
+static int stm32pwm_ioctl(struct pwm_lowerhalf_s *dev, int cmd,
unsigned long arg)
Review Comment:
```suggestion
unsigned long arg)
```
##########
arch/arm/src/stm32f0l0g0/stm32_serial_v1.c:
##########
@@ -2265,9 +2265,9 @@ static bool stm32serial_txready(FAR struct uart_dev_s
*dev)
#ifdef SERIAL_HAVE_RXDMA
static void stm32serial_dmarxcallback(DMA_HANDLE handle, uint8_t status,
- FAR void *arg)
+ void *arg)
Review Comment:
```suggestion
void *arg)
```
##########
arch/arm/src/stm32f0l0g0/stm32_tim_lowerhalf.c:
##########
@@ -119,14 +119,14 @@ static int stm32_timer_handler(int irq, void * context,
void * arg);
/* "Lower half" driver methods **********************************************/
-static int stm32_start(FAR struct timer_lowerhalf_s *lower);
-static int stm32_stop(FAR struct timer_lowerhalf_s *lower);
-static int stm32_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int stm32_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int stm32_start(struct timer_lowerhalf_s *lower);
+static int stm32_stop(struct timer_lowerhalf_s *lower);
+static int stm32_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
Review Comment:
```suggestion
static int stm32_getstatus(struct timer_lowerhalf_s *lower,
struct timer_status_s *status);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -716,7 +716,7 @@ static void stm32pwm_modifyreg(struct stm32_pwmtimer_s
*priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void stm32pwm_dumpregs(struct stm32_pwmtimer_s *priv,
- FAR const char *msg)
+ const char *msg)
Review Comment:
```suggestion
const char *msg)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
-static int stm32pwm_update_duty(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty);
-static void stm32pwm_setapbclock(FAR struct stm32_pwmtimer_s *priv, bool on);
+static void stm32pwm_setapbclock(struct stm32_pwmtimer_s *priv, bool on);
#if defined(CONFIG_PWM_PULSECOUNT) && \
(defined(CONFIG_STM32F0L0G0_TIM1_PWM) ||
defined(CONFIG_STM32F0L0G0_TIM8_PWM))
static int stm32pwm_interrupt(struct stm32_pwmtimer_s *priv);
# if defined(CONFIG_STM32F0L0G0_TIM1_PWM)
-static int stm32pwm_tim1interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim1interrupt(int irq, void *context, void *arg);
# endif
# if defined(CONFIG_STM32F0L0G0_TIM8_PWM)
-static int stm32pwm_tim8interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim8interrupt(int irq, void *context, void *arg);
# endif
static uint8_t stm32pwm_pulsecount(uint32_t count);
#endif /* CONFIG_PWM_PULSECOUNT && CONFIG_STM32F0L0G0_TIM{1,8}_PWM */
/* PWM driver methods */
-static int stm32pwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int stm32pwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int stm32pwm_setup(struct pwm_lowerhalf_s *dev);
+static int stm32pwm_shutdown(struct pwm_lowerhalf_s *dev);
#ifdef CONFIG_PWM_PULSECOUNT
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info,
- FAR void *handle);
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info,
+ void *handle);
#else
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -1935,11 +1935,11 @@ static int stm32pwm_start(FAR struct pwm_lowerhalf_s
*dev,
return stm32pwm_timer(priv, info);
}
#else
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info)
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info)
Review Comment:
```suggestion
static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -211,42 +211,42 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s
*priv,
/* Timer management */
-static int stm32pwm_timer(FAR struct stm32_pwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_timer(struct stm32_pwmtimer_s *priv,
+ const struct pwm_info_s *info);
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel);
-static int stm32pwm_update_duty(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty);
-static void stm32pwm_setapbclock(FAR struct stm32_pwmtimer_s *priv, bool on);
+static void stm32pwm_setapbclock(struct stm32_pwmtimer_s *priv, bool on);
#if defined(CONFIG_PWM_PULSECOUNT) && \
(defined(CONFIG_STM32F0L0G0_TIM1_PWM) ||
defined(CONFIG_STM32F0L0G0_TIM8_PWM))
static int stm32pwm_interrupt(struct stm32_pwmtimer_s *priv);
# if defined(CONFIG_STM32F0L0G0_TIM1_PWM)
-static int stm32pwm_tim1interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim1interrupt(int irq, void *context, void *arg);
# endif
# if defined(CONFIG_STM32F0L0G0_TIM8_PWM)
-static int stm32pwm_tim8interrupt(int irq, void *context, FAR void *arg);
+static int stm32pwm_tim8interrupt(int irq, void *context, void *arg);
# endif
static uint8_t stm32pwm_pulsecount(uint32_t count);
#endif /* CONFIG_PWM_PULSECOUNT && CONFIG_STM32F0L0G0_TIM{1,8}_PWM */
/* PWM driver methods */
-static int stm32pwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int stm32pwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int stm32pwm_setup(struct pwm_lowerhalf_s *dev);
+static int stm32pwm_shutdown(struct pwm_lowerhalf_s *dev);
#ifdef CONFIG_PWM_PULSECOUNT
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info,
- FAR void *handle);
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info,
+ void *handle);
#else
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
#endif
-static int stm32pwm_stop(FAR struct pwm_lowerhalf_s *dev);
-static int stm32pwm_ioctl(FAR struct pwm_lowerhalf_s *dev,
+static int stm32pwm_stop(struct pwm_lowerhalf_s *dev);
+static int stm32pwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
Review Comment:
```suggestion
static int stm32pwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -781,7 +781,7 @@ static void stm32pwm_dumpregs(struct stm32_pwmtimer_s *priv,
* Zero on success;
****************************************************************************/
-static int stm32pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel)
Review Comment:
```suggestion
static int stm32pwm_output_configure(struct stm32_pwmtimer_s *priv,
uint8_t channel)
```
##########
arch/arm/src/stm32f0l0g0/stm32_serial_v1.c:
##########
@@ -1573,15 +1573,15 @@ static int up_interrupt(int irq, FAR void *context, FAR
void *arg)
*
****************************************************************************/
-static int stm32serial_ioctl(FAR struct file *filep, int cmd,
+static int stm32serial_ioctl(struct file *filep, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int stm32serial_ioctl(struct file *filep, int cmd,
unsigned long arg)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -1452,7 +1452,7 @@ static int stm32pwm_timer(FAR struct stm32_pwmtimer_s
*priv,
*
****************************************************************************/
-static int stm32pwm_update_duty(FAR struct stm32_pwmtimer_s *priv,
+static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty)
Review Comment:
```suggestion
static int stm32pwm_update_duty(struct stm32_pwmtimer_s *priv,
uint8_t channel, ub16_t duty)
```
##########
arch/arm/src/stm32f7/stm32_dma.c:
##########
@@ -256,7 +256,7 @@ static inline void stm32_dmagive(FAR struct stm32_dma_s
*dmast)
*
****************************************************************************/
-static inline FAR struct stm32_dma_s *stm32_dmastream(unsigned int stream,
+static inline struct stm32_dma_s *stm32_dmastream(unsigned int stream,
unsigned int controller)
Review Comment:
```suggestion
static inline struct stm32_dma_s *stm32_dmastream(unsigned int stream,
unsigned int controller)
```
##########
arch/arm/src/stm32f0l0g0/stm32_tim_lowerhalf.c:
##########
@@ -650,8 +650,8 @@ int stm32_timer_initialize(FAR const char *devpath, int
timer)
* REVISIT: The returned handle is discard here.
*/
- FAR void *drvr = timer_register(devpath,
- (FAR struct timer_lowerhalf_s *)lower);
+ void *drvr = timer_register(devpath,
+ (struct timer_lowerhalf_s *)lower);
Review Comment:
```suggestion
void *drvr = timer_register(devpath,
(struct timer_lowerhalf_s *)lower);
```
##########
arch/arm/src/stm32f0l0g0/stm32_serial_v1.c:
##########
@@ -2309,7 +2309,7 @@ static void stm32serial_dmarxcallback(DMA_HANDLE handle,
uint8_t status,
****************************************************************************/
#ifdef CONFIG_PM
-static void stm32serial_pmnotify(FAR struct pm_callback_s *cb, int domain,
+static void stm32serial_pmnotify(struct pm_callback_s *cb, int domain,
enum pm_state_e pmstate)
Review Comment:
```suggestion
static void stm32serial_pmnotify(struct pm_callback_s *cb, int domain,
enum pm_state_e pmstate)
```
##########
arch/arm/src/stm32f0l0g0/stm32_pwm.c:
##########
@@ -1906,11 +1906,11 @@ static int stm32pwm_shutdown(FAR struct pwm_lowerhalf_s
*dev)
****************************************************************************/
#ifdef CONFIG_PWM_PULSECOUNT
-static int stm32pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info,
- FAR void *handle)
+static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info,
+ void *handle)
Review Comment:
```suggestion
static int stm32pwm_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
void *handle)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
