ddragosd commented on a change in pull request #2282: Distributed tracing
support #2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r118599136
##########
File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
##########
@@ -53,7 +54,8 @@ case class ActivationMessage(
activationId: ActivationId,
activationNamespace: EntityPath,
content: Option[JsObject],
- cause: Option[ActivationId] = None)
+ cause: Option[ActivationId] = None,
+ traceMetadata: Option[SpanMetadata] = None)
Review comment:
Are you suggesting to not include the tracing metadata in the data plane or
just be mindful about the size ?
If we don't include it, do we have a way around it without affecting latency
? If it had been an HTTP request, then the parent span ID would have been sent
as a header; in this case, with Kakfa, it's sent similarly; headers are like
the `metadata` IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
