ddragosd commented on a change in pull request #2282: Distributed tracing
support #2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r119140432
##########
File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
##########
@@ -53,7 +54,8 @@ case class ActivationMessage(
activationId: ActivationId,
activationNamespace: EntityPath,
content: Option[JsObject],
- cause: Option[ActivationId] = None)
+ cause: Option[ActivationId] = None,
+ traceMetadata: Option[SpanMetadata] = None)
Review comment:
> The tracing information has to round trip through Kafka; what's the cost
of doing that? Once we have the benchmarking strategy established in the open
it makes it easier to then speak about the effect of adding tracing on the
critical path in this way.
@rabbah does the sample message shared by @sandeep-paliwal help with the
concerns for cost and benchmarking strategies ? Are we worried for introducing
these 3 extra fields ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
