ddragosd commented on a change in pull request #2282: Distributed tracing
support #2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r118609460
##########
File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
##########
@@ -53,7 +54,8 @@ case class ActivationMessage(
activationId: ActivationId,
activationNamespace: EntityPath,
content: Option[JsObject],
- cause: Option[ActivationId] = None)
+ cause: Option[ActivationId] = None,
+ traceMetadata: Option[SpanMetadata] = None)
Review comment:
If the system has issues currently with the payload size sent to the actions
by the clients, then that's probably a separate conversation to have. A design
inspired from HTTP that sends the `headers`/`metadata` first, then streams the
content directly to the action, might be a less limiting one.
For this particular PR with tracing we're probably worrying about a tiny
slice of the current payload limit. We're probably talking about 1-4KB to be
generous ? If we move this information elsewhere, then we introduce latency b/c
the controller and invoker need to do an outbound request to get this info,
then I'm not sure of the benefits of tracing anymore, provided it impacts
latency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
