emkornfield commented on code in PR #189:
URL: https://github.com/apache/parquet-site/pull/189#discussion_r3470700287
##########
data/implementations/features/logical-types.yaml:
##########
@@ -2,81 +2,178 @@ category_id: logical-types
features:
- id: logical-string
display_name: STRING
-
+ version_display_name: STRING (BYTE_ARRAY)
+ compatibility: forward_compatible
+ released_in: 1.0.0
+ feature_url:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#string
+ source_url:
https://github.com/apache/parquet-format/tree/parquet-format-1.0.0
- id: logical-enum
display_name: ENUM
-
+ version_display_name: ENUM (BYTE_ARRAY)
+ compatibility: forward_compatible
+ released_in: 2.0.0
+ feature_url:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#enum
+ source_url:
https://github.com/apache/parquet-format/compare/parquet-format-1.0.0...parquet-format-2.0.0
- id: logical-uuid
display_name: UUID
-
+ version_display_name: UUID (FIXED_LEN_BYTE_ARRAY(16))
+ compatibility: forward_compatible
+ released_in: 2.6.0
+ feature_url:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#uuid
+ source_url:
https://github.com/apache/parquet-format/compare/apache-parquet-format-2.5.0...apache-parquet-format-2.6.0
- id: logical-int-types
display_name: 8, 16, 32, 64 bit signed and unsigned INT
-
+ version_display_name: Signed and unsigned integer logical types (INT32,
INT64)
+ compatibility: forward_compatible
Review Comment:
Yeah, this is broader discussion, I think we should clarify the wording
here. we can leave it as is, but I worry about the difference between
different semantics:
1. Losing information that a int64 represents a timestamp is fine in my
mind. It still looks like an integer, and following arithmetic properties.
2. Losing information that an int64 is actually a uint64 feels like a data
corruption case.
But I'd have to clarify my thinking here a bit more. We don't need to make
the change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
