krishan1390 commented on code in PR #15387: URL: https://github.com/apache/pinot/pull/15387#discussion_r2016483913
########## pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java: ########## @@ -18,195 +18,134 @@ */ package org.apache.pinot.common.metrics; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; import org.apache.pinot.common.Utils; - +import org.apache.pinot.spi.exception.QueryErrorCode; /** - * Enumeration containing all the metrics exposed by the Pinot broker. + * Class containing all the metrics exposed by the Pinot broker. Review Comment: wanted to create metrics dynamically for all error codes to prevent issues where developers forget to add a metric when adding a new error code. we can't do that with enums. and can't create a seperate class for that because AbstractMetrics can be created with just 1 instance of AbstractMetrics.Meter class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
