vrajat commented on code in PR #15387: URL: https://github.com/apache/pinot/pull/15387#discussion_r2017024787
########## pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java: ########## @@ -18,195 +18,134 @@ */ package org.apache.pinot.common.metrics; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; import org.apache.pinot.common.Utils; - +import org.apache.pinot.spi.exception.QueryErrorCode; /** - * Enumeration containing all the metrics exposed by the Pinot broker. + * Class containing all the metrics exposed by the Pinot broker. Review Comment: This is a big structural change in terms of dev u/x. Metrics for other components as well as in Startree follow the current pattern. So this will become an odd one out. Are there other ways to achieve what you need ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
