vrajat commented on code in PR #15387:
URL: https://github.com/apache/pinot/pull/15387#discussion_r2017135992
##########
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcServer.java:
##########
@@ -181,15 +182,17 @@ public void submit(Broker.BrokerRequest request,
try {
sqlNodeAndOptions = RequestUtils.parseQuery(query, requestJsonNode);
} catch (Exception e) {
- // Do not log or emit metric here because it is pure user error
Review Comment:
In this block, only `SQL_PARSING` error can be thrown. So a simpler change
is to increment the specific meter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
