krishan1390 commented on code in PR #15387: URL: https://github.com/apache/pinot/pull/15387#discussion_r2017949534
########## pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java: ########## @@ -18,195 +18,134 @@ */ package org.apache.pinot.common.metrics; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; import org.apache.pinot.common.Utils; - +import org.apache.pinot.spi.exception.QueryErrorCode; /** - * Enumeration containing all the metrics exposed by the Pinot broker. + * Class containing all the metrics exposed by the Pinot broker. Review Comment: tried creating a seperate class but AbstractMetrics restricts that. thanks for the javadocs catch. I missed seeing it got removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
