J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2019086302
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -662,6 +663,20 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
Set<String> serversRemoved = new HashSet<>();
Set<String> serversUnchanged = new HashSet<>();
Set<String> serversGettingNewSegments = new HashSet<>();
+ Map<String, RebalanceSummaryResult.TenantInfo> tenantInfoMap = new
HashMap<>();
+ String serverTenantName = tableConfig.getTenantConfig().getServer();
Review Comment:
For my understanding, tag pool tag could also be applied for a certain tier
e.g. having
```
instanceAssignment: {
"tierA": {
"tagPoolConfig": {
"tag": "Tag1_OFFLINE",
"poolBased": true
},
...
}
}
```
This case it's possible to have both server tenant tag and pool tag in some
assigned instances. It would need more logics to determine whether a server
tenant is completely overridden?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
