J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2019088428
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -699,6 +723,28 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
serverSegmentChangeInfoMap.put(server, new
RebalanceSummaryResult.ServerSegmentChangeInfo(serverStatus,
totalNewSegments, totalExistingSegments, segmentsAdded,
segmentsDeleted, segmentsUnchanged,
instanceToTagsMap.getOrDefault(server, null)));
+ List<String> serverTags = getServerTag(server);
+ Set<String> relevantTags = new HashSet<>(serverTags);
+ relevantTags.retainAll(tagsInfoMap.keySet());
+ // The segments remain unchanged or need to download will be accounted
to every tag associated with this
+ // server instance
+ if (relevantTags.isEmpty()) {
Review Comment:
It's possible when rebalance with `reassignInstance=false` under some cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
