J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2019188598
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -662,6 +663,20 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
Set<String> serversRemoved = new HashSet<>();
Set<String> serversUnchanged = new HashSet<>();
Set<String> serversGettingNewSegments = new HashSet<>();
+ Map<String, RebalanceSummaryResult.TenantInfo> tenantInfoMap = new
HashMap<>();
+ String serverTenantName = tableConfig.getTenantConfig().getServer();
Review Comment:
Technically we can check if the tag pool config is set for "OFFLINE", or
both "COMPLETED" and "CONSUMING".
But to insert the tag priority logic here could be a bit overkill. I prefer
to keep it clean and simple here to include every tag "mentioned" in the table
config and let users decide which to care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
