somandal commented on code in PR #15618:
URL: https://github.com/apache/pinot/pull/15618#discussion_r2071597362
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -1387,9 +1444,13 @@ private static boolean isExternalViewConverged(String
tableNameWithType,
continue;
}
- // ExternalView should contain the segment
+ // If the segment has not shown up in ExternalView, it is not added yet
if (externalViewInstanceStateMap == null) {
- return false;
+ remainingSegmentsToProcess++;
+ if (earlyReturn) {
+ return 1;
Review Comment:
Good point. Just thinking out loud, instead of returning 1 should we just
return the number of segments counted so far? That’ll always be > 0 if there
are segments that need to converge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
