J-HowHuang commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2078488673
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -224,6 +225,9 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
int minReplicasToKeepUpForNoDowntime =
rebalanceConfig.getMinAvailableReplicas();
boolean lowDiskMode = rebalanceConfig.isLowDiskMode();
boolean bestEfforts = rebalanceConfig.isBestEfforts();
+ int batchSizePerServer = rebalanceConfig.getBatchSizePerServer();
+ Preconditions.checkState(batchSizePerServer != 0 && batchSizePerServer >=
-1,
+ "TableRebalance batchSizePerServer must be > 0 or -1 to disable");
Review Comment:
oh okay the checks are before making assignment, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
