vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2115541417
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -240,12 +241,13 @@ private List<String> getInstanceIds(String query,
List<String> tableNames, Strin
List<String> instanceIds;
if (!tableNames.isEmpty()) {
List<TableConfig> tableConfigList = getListTableConfigs(tableNames,
database);
- if (tableConfigList == null || tableConfigList.isEmpty()) {
+ List<LogicalTableConfig> logicalTableConfigList =
getListLogicalTableConfigs(tableNames, database);
+ if ((tableConfigList == null || tableConfigList.isEmpty()) &&
logicalTableConfigList.isEmpty()) {
Review Comment:
in `getListTableConfig`, the following if condition is triggered if no
offline or realtime table is found for one of the items in the list. Thats why
a null check is required. I have added `@Nullable` annotation to
`getListTableConfigs`. I dont know the reason for this behaviour.
```
if (tableConfigList.isEmpty()) {
return null;
}
```
Hmm - I should do the same for logical tables ? This code needs work. The
code has to throw if no table or logical table config is found for a specific
entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
