vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2115914194
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -240,12 +241,30 @@ private List<String> getInstanceIds(String query,
List<String> tableNames, Strin
List<String> instanceIds;
if (!tableNames.isEmpty()) {
List<TableConfig> tableConfigList = getListTableConfigs(tableNames,
database);
- if (tableConfigList == null || tableConfigList.isEmpty()) {
- throw QueryErrorCode.TABLE_DOES_NOT_EXIST.asException("Unable to find
table in cluster, table does not exist");
+ List<LogicalTableConfig> logicalTableConfigList = null;
+ // First check for table configs, if not found, check for logical table
configs.
+ if (tableConfigList.size() != tableNames.size()) {
+ logicalTableConfigList = getListLogicalTableConfigs(tableNames,
database);
+ // If config is not found for all tables, then find the tables that
are not found.
+ if ((tableConfigList.size() + logicalTableConfigList.size()) !=
tableNames.size()) {
Review Comment:
Yes. Names are unique among tables and logical tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
