vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2115618937
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -240,12 +241,13 @@ private List<String> getInstanceIds(String query,
List<String> tableNames, Strin
List<String> instanceIds;
if (!tableNames.isEmpty()) {
List<TableConfig> tableConfigList = getListTableConfigs(tableNames,
database);
- if (tableConfigList == null || tableConfigList.isEmpty()) {
+ List<LogicalTableConfig> logicalTableConfigList =
getListLogicalTableConfigs(tableNames, database);
+ if ((tableConfigList == null || tableConfigList.isEmpty()) &&
logicalTableConfigList.isEmpty()) {
Review Comment:
This change was more complicated than I imagined. However I have added tests
in `BaseLogicalTableIntegrationTest`. Tell me if you are more comfortable if I
remove the diff for controller submit. I can create a separate PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
