jenniferdai commented on a change in pull request #4664: Support other
filesystems for Pinot Hadoop job
URL: https://github.com/apache/incubator-pinot/pull/4664#discussion_r330698139
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.java
##########
@@ -148,7 +148,8 @@ public void setup(Context context)
Preconditions.checkState(_localSegmentDir.mkdir());
Preconditions.checkState(_localSegmentTarDir.mkdir());
- _fileSystem = FileSystem.get(context.getConfiguration());
+ // Note: we made an assumption that input file and output path are using
same filesystem.
+ _fileSystem = FileSystem.get(_hdfsSegmentTarDir.toUri(),
context.getConfiguration());
Review comment:
If I'm not misunderstanding, this one will always be local, right? It's
assigned with FileOutputFormat.getWorkOutputPath(context)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
