jenniferdai commented on a change in pull request #4664: Support other
filesystems for Pinot Hadoop job
URL: https://github.com/apache/incubator-pinot/pull/4664#discussion_r331146319
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.java
##########
@@ -277,6 +277,12 @@ protected FileFormat getFileFormat(String fileName) {
if (fileName.endsWith(".thrift")) {
return FileFormat.THRIFT;
}
+ if (fileName.endsWith(".parquet")) {
+ return FileFormat.PARQUET;
+ }
+ if (fileName.endsWith(".orc")) {
Review comment:
We count ORC as FileFormat.OTHER and set the record reader path to the
ORCRecordReader, so you don't need to include the orc-specific logic for
segmentcreation to work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
