jenniferdai commented on a change in pull request #4664: Support other
filesystems for Pinot Hadoop job
URL: https://github.com/apache/incubator-pinot/pull/4664#discussion_r330697422
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
##########
@@ -108,15 +108,15 @@ protected boolean isDataFile(String fileName) {
return true;
}
return fileName.endsWith(".avro") || fileName.endsWith(".csv") ||
fileName.endsWith(".json") || fileName
- .endsWith(".thrift");
+ .endsWith(".thrift") || fileName.endsWith(".parquet") ||
fileName.endsWith(".orc");
Review comment:
You shouldn't need fileName.endsWith(".orc"), as the way ORC readers are
currently configured go through JobConfigConstants.RECORD_READER_PATH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
