johnsolomonj commented on PR #18185: URL: https://github.com/apache/pinot/pull/18185#issuecomment-4607273688
> a few things: > > 1. add docs for all the public apis and configs > 2. java docs should follow markdown style and start with `///` > 3. pinot supports both dictionary + raw forward index, so just checking either to determine the existence of the other won't persist. 1. Added /// Javadoc to all new public classes (ColumnCompressionStatsInfo, CompressionStatsSummary) and the compressionStatsEnabled config field. 2. Converted all class-level docs to /// markdown style. 3. Addressed. `hasDictionary` is removed and codec is the single source of truth. Dict columns set codec="DICT_ENCODED", so checking one encoding no longer implies anything about the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
