johnsolomonj commented on code in PR #18185:
URL: https://github.com/apache/pinot/pull/18185#discussion_r3388324021
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##########
@@ -92,6 +92,8 @@ public class VarByteChunkForwardIndexWriterV4 implements
VarByteChunkWriter {
private int _nextDocId = 0;
private int _metadataSize = 0;
private long _chunkOffset = 0;
+ private long _uncompressedSize = 0;
+ private boolean _trackUncompressedSize = true;
Review Comment:
The default of `true` was effectively overridden by
`setTrackUncompressedSize(false)` via `ForwardIndexCreatorFactory` before any
writes happened, so it wasn't causing incorrect behavior. But `false` is the
right default for clarity and safety. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
