johnsolomonj commented on code in PR #18185:
URL: https://github.com/apache/pinot/pull/18185#discussion_r3388427396
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##########
@@ -268,6 +275,22 @@ private static long unpackIndexSize(long typeAndSize) {
return typeAndSize & SIZE_MASK;
}
+ @Override
+ public long getUncompressedForwardIndexSizeBytes() {
+ return _uncompressedForwardIndexSizeBytes;
+ }
+
+ @Override
+ @Nullable
+ public String getCompressionCodec() {
Review Comment:
`getCompressionCodec()` can return a `ChunkCompressionType` name,
`"DICT_ENCODED"`, or `"MIXED"` — a new enum would either duplicate
`ChunkCompressionType` values (and drift when new codecs are added) or require
a wrapper that still needs a `String` fallback. Kept it as `String` to avoid
that coupling. Open to suggestions if there's a cleaner pattern you have in
mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
