rohityadav1993 commented on code in PR #18641:
URL: https://github.com/apache/pinot/pull/18641#discussion_r3440955824
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java:
##########
@@ -107,6 +111,11 @@ public PredownloadScheduler(PropertiesConfiguration
properties)
_failedSegments = ConcurrentHashMap.newKeySet();
_executor = Executors.newFixedThreadPool(predownloadParallelism);
LOGGER.info("Created thread pool with num of threads: {}",
predownloadParallelism);
+
+ _peerDownloadEnabled = peerDownloadEnabled;
+ _peerDownloadScheme =
_instanceDataManagerConfig.getSegmentPeerDownloadScheme();
Review Comment:
nit: Let's sanitize this similar to:
https://github.com/apache/pinot/blob/5526d5b86018bc8d22e10ece356d107dff5e280f/pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java#L242-L247
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadZKClient.java:
##########
@@ -147,6 +149,51 @@ public List<PredownloadSegmentInfo>
getSegmentsOfInstance(HelixDataAccessor acce
return predownloadSegmentInfos;
}
+ /**
+ * Returns URIs of ONLINE peer servers hosting the given segment, excluding
the current instance.
Review Comment:
nit: "excluding the current instance" This will always be excluded as
predownload runs even before server process starts so EV will not have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
