pradeeee commented on code in PR #18641:
URL: https://github.com/apache/pinot/pull/18641#discussion_r3448437476
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadZKClient.java:
##########
@@ -147,6 +149,51 @@ public List<PredownloadSegmentInfo>
getSegmentsOfInstance(HelixDataAccessor acce
return predownloadSegmentInfos;
}
+ /**
+ * Returns URIs of ONLINE peer servers hosting the given segment, excluding
the current instance.
Review Comment:
The comment is wrong; in the current code, we are taking all the nodes that
have a segment hosted and in an online state. This can include the Old node
from which replacement is triggered.
The idea is that wherever the segment is healthy, download from there, for
some cases where segment is not committed to peer node it will be ava in the
old node only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
