shauryachats commented on code in PR #18641:
URL: https://github.com/apache/pinot/pull/18641#discussion_r3522779274
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java:
##########
@@ -107,6 +112,18 @@ public PredownloadScheduler(PropertiesConfiguration
properties)
_failedSegments = ConcurrentHashMap.newKeySet();
_executor = Executors.newFixedThreadPool(predownloadParallelism);
LOGGER.info("Created thread pool with num of threads: {}",
predownloadParallelism);
+
+ _peerDownloadEnabled =
properties.getBoolean("pinot.server.peer.download.enabled", false);
Review Comment:
Can we put `pinot.server.peer.download.enabled` in the defined configs file
and use it from there? I think we also have getter methods there - it makes it
clearer and reusable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
