Akanksha-kedia opened a new pull request, #18820:
URL: https://github.com/apache/pinot/pull/18820

   ## Summary
   
   Fixes #9683
   
   When a column appears in `TIMESERIESON` but is omitted from the `SELECT` 
list, `indexes.get(entityColum.getIdentifier())` returned `null` and 
auto-unboxing to `int` threw a silent `NullPointerException` at 
`GapfillProcessor.process`.
   
   **Fix:** Replace the bare unbox with an explicit null check. If a 
`TIMESERIESON` column is missing from the result schema, throw 
`BadQueryRequestException` with a descriptive message so callers get an 
actionable error instead of a stack trace.
   
   ## Changes
   
   - `GapfillProcessor.java`: null-check `indexes.get()` result and throw 
`BadQueryRequestException` when a TIMESERIESON column is absent from the SELECT 
list
   - `GapfillQueriesTest.java`: add regression test 
`testGapfillThrowsOnTimeseriesOnColumnNotInSelect` verifying the exception is 
raised
   
   ## Test plan
   
   - [ ] `GapfillQueriesTest#testGapfillThrowsOnTimeseriesOnColumnNotInSelect` 
— new test that asserts `BadQueryRequestException` is thrown for the failing 
query
   - [ ] All existing `GapfillQueriesTest` cases continue to pass
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to