Akanksha-kedia commented on code in PR #18820:
URL: https://github.com/apache/pinot/pull/18820#discussion_r3472102274
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java:
##########
@@ -89,7 +90,12 @@ public void process(BrokerResponseNative
brokerResponseNative) {
// The first one argument of timeSeries is time column. The left ones are
defining entity.
for (ExpressionContext entityColum : _timeSeries) {
- int index = indexes.get(entityColum.getIdentifier());
+ String colName = entityColum.getIdentifier();
+ Integer index = indexes.get(colName);
+ if (index == null) {
+ throw new BadQueryRequestException(
Review Comment:
Addressed — the validation now happens in
`GapfillUtils.stripGapfill(PinotQuery)`, which is called at query compile time
before any server round-trip. The null-check in `GapfillProcessor` is kept as a
safety net but the user-facing error is thrown earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
