Jackie-Jiang commented on code in PR #18820:
URL: https://github.com/apache/pinot/pull/18820#discussion_r3454979844
##########
pinot-common/src/test/java/org/apache/pinot/common/function/scalar/StringFunctionsTest.java:
##########
@@ -601,6 +601,7 @@ public void testTranslate() {
assertEquals(StringFunctions.translate("aaa", "aa", "XY"), "XXX");
}
+
Review Comment:
(minor) Revert
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -1158,6 +1158,7 @@ public static String translate(String input, String from,
String to) {
return sb.toString();
}
+
Review Comment:
(minor) Revert
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java:
##########
@@ -89,7 +90,12 @@ public void process(BrokerResponseNative
brokerResponseNative) {
// The first one argument of timeSeries is time column. The left ones are
defining entity.
for (ExpressionContext entityColum : _timeSeries) {
- int index = indexes.get(entityColum.getIdentifier());
+ String colName = entityColum.getIdentifier();
+ Integer index = indexes.get(colName);
+ if (index == null) {
+ throw new BadQueryRequestException(
Review Comment:
Ideally we should validate the query before sending the query to servers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
