Jackie-Jiang opened a new pull request, #18904:
URL: https://github.com/apache/pinot/pull/18904

   ## Summary
   
   Add a new stream config `partition.consumption.rate.limit` to set the 
realtime consumption rate limit directly at partition level. Unlike the 
existing `topic.consumption.rate.limit` (which is divided by the topic's 
partition count), the partition level limit doesn't need to be reconfigured 
when the partition count changes.
   
   - `RealtimeConsumptionRateManager.createRateLimiter` checks the partition 
level limit first and uses it directly, skipping the partition count fetch (and 
its cache) entirely. When both are specified, partition level limit takes 
precedence. Topic level behavior is unchanged.
   - Both rate limit getters in `StreamConfig` now return primitive `double` 
(non-positive means not throttled) instead of `Optional<Double>`, consistent 
with other configs. `CONSUMPTION_RATE_LIMIT_NOT_SPECIFIED` is made public.
   - Cleanup: removed dead `_groupId` / `getGroupId()` from `StreamConfig` and 
the unused `GROUP_ID` (`hlc.group.id`, HLC legacy) and 
`PARTITION_MSG_OFFSET_FACTORY_CLASS` keys from `StreamConfigProperties`; 
reordered `equals` / `hashCode` / `toString` to match field declaration order 
and fixed two malformed `toString` labels (missing `=`, `_offSet` typo).
   
   Note: `getTopicConsumptionRateLimit()` signature change and the removed dead 
members are binary-incompatible for third-party plugins compiled against 
`pinot-spi`. There are no callers in the Pinot codebase.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to