Jackie-Jiang commented on code in PR #18904:
URL: https://github.com/apache/pinot/pull/18904#discussion_r3509492761
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfigProperties.java:
##########
@@ -45,8 +45,7 @@ private StreamConfigProperties() {
public static final String STREAM_IDLE_TIMEOUT_MILLIS =
"idle.timeout.millis";
public static final String STREAM_DECODER_CLASS = "decoder.class.name";
public static final String DECODER_PROPS_PREFIX = "decoder.prop";
- public static final String GROUP_ID = "hlc.group.id";
- public static final String PARTITION_MSG_OFFSET_FACTORY_CLASS =
"partition.offset.factory.class.name";
+ public static final String PARTITION_CONSUMPTION_RATE_LIMIT =
"partition.consumption.rate.limit";
public static final String TOPIC_CONSUMPTION_RATE_LIMIT =
"topic.consumption.rate.limit";
Review Comment:
These keys are dead: `hlc.group.id` is legacy from the long-removed
high-level consumer, and `partition.offset.factory.class.name` is read by
nothing in the codebase. Keeping a `@Deprecated` constant for a config key that
no code consumes would be misleading — any plugin referencing them was already
getting no behavior. The removal is called out in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
